add data manager auth check for the new patch API

Merge request template

issue: #224 the new patch API is missed the data root auth check

assigned to @mzhu9

changed title from add data manager auth check for the new batch API to add data manager auth check for the new patch API

added 1 commit

• ad9cdca0 - update NOTICE

Compare with previous version

changed milestone to %M24 - Release 0.27

added Common Code label

approved this merge request

added 1 commit

• 3a2aa655 - update NOTICE

Compare with previous version

reset approvals from @nthakur by pushing to the branch

@Srinivasan_Narayanan @Rustam_Lotsmanenko Since you approved this MR before, you have the context, it is the same fix, but I just realized that storage has this new Patch API which requires the same data auth logic.

@ydzeng please also review from aws side.

@Stanislav_Riabokon Could you please help on the core int test failures. I don't think those failures are related, we do not expect this change would impact any existing int tests.

approved this merge request

unapproved this merge request

@mzhu9 aws integration tests are failling for the following error. please double check if there is any test changes required

2024-05-21T18:29:28.236Z ERROR 7 --- [nio-8080-exec-1] o.o.o.c.common.logging.DefaultLogWriter  : storage.app: error getting data authorization result
AppException(error=AppError(code=500, reason=error in data authorization, message=error getting data authorization result, errors=null, debuggingInfo=null, originalException=null), originalException=null)
	at org.opengroup.osdu.storage.opa.service.OPAServiceImpl.evaluateDataAuthorizationPolicy(OPAServiceImpl.java:111)

resolved all threads

approved this merge request

added 1 commit

• e5324ccf - Updating NOTICE

Compare with previous version

reset approvals from @solxget by pushing to the branch

resolved all threads

Thanks @divido for fixing the NOTICE, may I know how did you fix that? I downloaded the artifact and replace by cached-NOTICE and generated-clean-NOTIC, none of them work, is there any other trick to fix this issue?

all csp int tests passed.

@Srinivasan_Narayanan @Rustam_Lotsmanenko please take a look to see whether you have any concerns from azure and gc sides.

@Stanislav_Riabokon please help to take a look at the core int tests to see whether there is any concerns. This MR should not fail any existing int tests IMO unless they set up incorrectly.

@chad @nthakur

approved this merge request