Response with 400 (Bad request) when record id is longer than 512 bytes

Issue 1 - #256 (closed) Issue 2 - indexer-service#150

added Common Code label

requested review from @nthakur

assigned to @ykondakov

added 1 commit

• 8288ff10 - return 400 Bad request when PUT record with recordId greater than 512 bytes

Compare with previous version

approved this merge request

approved this merge request

Shouldn't this really be http status 413 (Content too large)?

unapproved this merge request

approved this merge request

@ykondakov - are there any concerns with including this in the M24 release? If not, can you tag this MR for M24 milestone and I can cherry-pick it to the release branch?

Can we please update the documentation for this change: https://community.opengroup.org/osdu/platform/system/storage/-/blob/master/docs/docs/index.md?ref_type=heads

changed milestone to %M25 - Release 0.28

added MREnhancement label

added MRBugfix label and removed MREnhancement label

added 1 commit

• ee88fbd4 - update record id documentation

Compare with previous version

reset approvals from @Rustam_Lotsmanenko and @marcburnie by pushing to the branch

added Breaking Change label

removed Breaking Change label

Hi @ykondakov, @nthakur - after some discussion with @divido - I think this falls under the case of "Corrective Semantic Changes" as detailed in the PMC policy page - this is a deviation of the standard that should be classified as a "Bug" rather than a change of intended behavior.

In the case of a true "breaking change", the right approach will be introducing it as a new version of API as per the semantic versioning.

Let me know what you think.

added 1 commit

• eed591a2 - update NOTICE

Compare with previous version

resolved all threads

approved this merge request

approved this merge request

merged

mentioned in commit 3efb3922