[Register Service] TopicsRepository in register-core retrieves topics from a json file

In it's current state the GET api/register/v1/topics API retrieves topics from a json file which it reads from the classpath.

Code can be found here:

TopicsRepository

TopicsRepository should be moved outside core code.

We need some clarity on who would be creating the topics and in that case would we need to add PUT and DELETE APIs for TopicsRepository?

changed milestone to %M1 - Release 0.1

marked this issue as related to #6 (closed)

@ethiraj , plz check and provide feedback.

@komakkar can you please take a look? also @osdu/platform/roles/azure-contributors

added Common Code KBUp Next R3 Development labels

@deshruch Thanks for reviewing and providing comments. Further review I noticed couple of things.

a) There is no SPI for GET /topics

b) There is test class in core main API(SubscriberTestListenerApi)

c) GET /topics is simply reading from JSON file, this will not work for other CSPs.

I had chat with @nthakur, the consumer of this API is notification service but I think we should cleanup and provide additional details.

@ChrisZhang this is for our team to fix. @nthakur please add additional information.

@wsmatth , please check and help provide urgency of this issue.

Hi @ChrisZhang, It would be nice to have a walkthrough of the service so we can see the purpose of the topics listed in the json. If the topics are intended to be dynamic and not hardcoded, this issue is a blocker as it forces us to build the topics at compile time into the jar. As @ethiraj mentioned in his comment, it would be good to go ahead and address the additional issue he brought up with the /topics SPIs missing.

Recording of walkthrough: https://opensdu.slack.com/archives/C013WJUBXQC/p1596055247054500

@deshruch Topic listed in the JSON is used for broadcasting Storage service data change event.

Topics are intended to be dynamic in future but in the near-term we don't have any requirement to expand the list of supported topics.

In near term, we can still move this implementation to SPI so it can unblock you.

@nthakur It will good to introduce SPI

For the azure implementation, post data partition changes topic names will be prefixed with the partition name (in order to generate DNS unique values) and will be read from Key vault

More details here

mentioned in merge request !26 (merged)

@ethiraj Will review and update

added 1 deleted label and removed KBUp Next label

This issue hasn't been updated in over 6 months, so I am closing it to reduce clutter in the issue list. If this a mistake, feel free to re-open the issue.

This action was performed en masse by a script.

added Auto Close label

closed