Adding ITopicsRepository Interface
Type of change
-
Refactoring
Please provide link to gitlab issue or ADR(Architecture Decision Record) #14 (closed)
Does this introduce a change in the core logic?
- [YES]
Does this introduce a change in the cloud provider implementation, if so which cloud?
-
AWS -
Azure -
GCP -
IBM
Does this introduce a breaking change?
- [NO]
What is the current behavior?
Currently there is no SPI to implement for TopicsRepository
What is the new/expected behavior?
Adding ITopicsRepository Interface, CSP's can implement this interface to override the logic for reading the topic names
If any CSP wish not to implement this interface then also things will continue to work since TopicRepository in register core is already implementing the same
Have you added/updated Unit Tests and Integration Tests?
Any other useful information
Merge request reports
Activity
@deshruch please review/approve
@ethiraj @harshit283 Agree with this change since it is a non-breaking and non-binding change for other CPs.
added 13 commits
-
f576d378...b66f0139 - 12 commits from branch
master
- 92ce4c5e - Merge branch 'master' into haaggarw/AddingITopicsRepositoryInterface
-
f576d378...b66f0139 - 12 commits from branch
Thanks @harshit283 for the MR. Pipeline looks good I will merge it.
mentioned in commit 965c00b4
added Common Code label
added MRRefactor label and removed Common Code label
added Azure Common Code labels
removed Azure label
changed milestone to %M1 - Release 0.1