Enable highlighting results

Type of change

• Bug Fix
• Feature

Changes related to the ADR: #128 (closed)

Does this introduce a change in the core logic?

• [NO]

Does this introduce a change in the cloud provider implementation, if so which cloud?

• AWS
• Azure
• Google Cloud
• IBM

Changes are for all provider however related code before and and after changes fully identical.

Does this introduce a breaking change?

• [NO] This feature had some different implementation before, but it was never enabled. Also it wasn't working correctly as it wasn't handling json paths so only top level field could be selected and there was no support for list fields.

What is the current behavior?

Currently there is no highlighting available for the users

What is the new/expected behavior?

Users can specify optional field highlightedFields which will add to each search result additional dictionary under key highlight with phrases from selected fields which matched the query. Example in the updated docs

Have you added/updated Unit Tests and Integration Tests?

Unit tests have been updated and some were added

Any other useful information

marked this merge request as ready

added Common Code MRNew Feature labels

changed milestone to %M20 - Release 0.23

added 1 commit

• 8795140d - Enable highlighting results

Compare with previous version

added 9 commits

• 8795140d...3b84949e - 8 commits from branch master
• 49b4b6f2 - Enable highlighting results

Compare with previous version

mentioned in merge request osdu/platform/system/lib/core/os-core-common!226 (merged)

changed the description

Unit test was added for only provider. Can add for others?

I know, Search service impl classes can be refactored so we don't have add same code in all places, but until then please provide the tests.

Can you please add/update at least one integration tests for this functionality?

added 1 commit

• 7c7229f2 - Enable highlighting results

Compare with previous version

added 33 commits

• 7c7229f2...363a4c49 - 32 commits from branch master
• abdde98e - Merge branch 'master' into sbstan/enable-highlighting-results

Compare with previous version

added 1 commit

• add7091f - Update pom.xml - use 23.0-SNAPSHOT of oscorecommon

Compare with previous version

resolved all threads

requested review from @nthakur

assigned to @sbstan

resolved all threads

resolved all threads

resolved all threads

resolved all threads

added 3 commits

• add7091f...aa6694df - 2 commits from branch master
• d715842c - Merge remote-tracking branch 'origin/master' into sbstan/enable-highlighting-results

Compare with previous version

added 1 commit

• 5253210b - Update pom.xml - fix oscorecommon reference

Compare with previous version

added 1 commit

• 1eaa08d6 - Update pom.xml - fix oscorecommon reference

Compare with previous version

added 1 commit

• 593a4501 - Enable highlighting results

Compare with previous version

added 1 commit

• 944878bb - update core common reference to version 0.23.1

Compare with previous version

resolved all threads

Please review -- all pipelines run as much as to be expected... CC @Rustam_Lotsmanenko @ydzeng @Srinivasan_Narayanan @nthakur

approved this merge request

Hi @Java1Guy Azure approved.

AWS Approved.

approved this merge request

I can't speak to the quality of the code, but the dependency changes look good. It's got three approvals, and the only failing CI job also fails on master. I think I'm going to hazard a merge on this one; I don't see it getting any more approved.

mentioned in commit 1641017b

merged

mentioned in merge request !553 (merged)