Skip to content
Snippets Groups Projects

SPI for PubSubRequestExtractor and handshake request handler.

Merged SPI for PubSubRequestExtractor and handshake request handler.
creating_spi_for_pubsubhandshake_pubsubrequestextractor into master
Merged Komal Makkar requested to merge creating_spi_for_pubsubhandshake_pubsubrequestextractor into master

Description

Added SPI to provider.interfaces package.

  1. IPubsubRequestBodyExtractor: as all provider PubSub will have their own Request body data contract.
  2. IPubsubHandshakehandler : as some providers will have to validate the endpoint at the application layer.

How to test / repro

  • Deploy the services locally run integration Tests

Changes include

  • Refactor (a non-breaking change that improves code maintainability).
  • Bugfix (a non-breaking change that solves an issue).
  • New feature (a non-breaking change that adds functionality).
  • Breaking change (a change that is not backward-compatible and/or changes current functionality).

Checklist

  • Added Unit Tests, wherever applicable.
  • Updated the Readme
  • Existing Tests pass
  • Verified functionality locally
  • Self Reviewed my code for formatting and complex business logic.

Other comments

  • moved the implementation to notification-gcp
  • the unimplemented methods in notification-gcp are not throwing, returning a default value.

@danielscholl @dkodeih FYI

Edited by Komal Makkar

Merge request reports

Merge request pipeline #6470 passed

Stage: review
Pipeline: Notification

#6471

    Merge request pipeline passed for 5a4e8111

    Approval is optional

    Merged by Hema Vishnu Pola [Microsoft]Hema Vishnu Pola [Microsoft] 4 years ago (Aug 25, 2020 1:02pm UTC)

    Merge details

    • Changes merged into with 19677ab8.
    • Deleted the source branch.

    Pipeline #6511 failed

    Stage: build
    Stage: scan
    Stage: attribution

    Pipeline failed for 19677ab8 on master

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
    Please register or sign in to reply