Skip to content
Snippets Groups Projects

Refactor the augmenter to search and fetch indexed data from the ElasticSearch service directly

Merged Zhibin Mai requested to merge augmenter_refactoring_search into master
All threads resolved!

Augmenter indexing searches and fetches related data/records from the Elasticsearch Indices instead of OSDU Storage in order to complete the augmenter indexing process. Since augmenter indexing was introduced in M18, it calls the OSDU Search service instead of Elasticsearch directly to search and fetch the data. One of the reasons on choosing this strategy was to avoid overwhelming code changes by reusing the OSDU Search with easy-to-use query syntax.

However, calling OSDU Search instead of Elasticsearch does introduce unnecessary overhead on the OSDU Search which could be shared by multi-tenants. Performance-wide, it may not be a good option too.

As Augmenter becomes stable, in this MR, we refactor the Augmenter to searches and fetches related data/records via the Elasticsearch service directly. To reduce the duplicate codes between the indexer and search services and complexity, only a small portion of the codes were copied from the search service. The construction of the queries with nested query needs to be predefined.

Edited by Zhibin Mai

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Zhibin Mai added 1 commit

    added 1 commit

    Compare with previous version

  • Zhibin Mai resolved all threads

    resolved all threads

  • Zhibin Mai added 1 commit

    added 1 commit

    • 98581211 - Add unit test to detect any change on the original object caused by method...

    Compare with previous version

  • Zhibin Mai added 1 commit

    added 1 commit

    • 607654e9 - Fix the potential issue on search with search_after and pit

    Compare with previous version

  • Zhibin Mai added 1 commit

    added 1 commit

    Compare with previous version

  • Yong Zeng approved this merge request

    approved this merge request

  • Author Maintainer

    @ydzeng Thanks!

  • Zhibin Mai requested review from @mzhu9

    requested review from @mzhu9

  • Mingyang Zhu approved this merge request

    approved this merge request

  • Jordan Chiu
  • Jiman Kim approved this merge request

    approved this merge request

  • Zhibin Mai resolved all threads

    resolved all threads

  • Jordan Chiu approved this merge request

    approved this merge request

  • Author Maintainer
  • Zhibin Mai requested review from @jordanchiu and @kimjiman

    requested review from @jordanchiu and @kimjiman

  • Riabokon Stanislav(EPAM)[GCP] approved this merge request

    approved this merge request

  • Author Maintainer
  • Zhibin Mai mentioned in commit dfb961e7

    mentioned in commit dfb961e7

  • merged

  • Please register or sign in to reply
    Loading