Create index alias when index is created
This is part of solution to fix the issue Multi kind search does not work with more than approximately 85 kinds
Merge request reports
Activity
assigned to @zhibinmai
added 1 commit
- eab4a842 - Failure to create the alias should not have impact on the status of index creation
added 3 commits
-
eab4a842...417c93ef - 2 commits from branch
master
- cdc361a2 - Merge branch 'master' of https://community.opengroup.org/osdu/platform/system/indexer-service
-
eab4a842...417c93ef - 2 commits from branch
requested review from @fhoueto.amz, @Rostislav_Dublin, @krveduru, @spencer, and @jingdongsun
@fhoueto.amz @Rostislav_Dublin @krveduru @spencer @jingdongsun Please help review this MR. The indexer creates the alias of the index (name) when the index is created
- Resolved by Zhibin Mai
Is it possible to add an integration test that verifies that the alias exists at Elasticsearch?
@Rustam_Lotsmanenko It is fair to add integration tests though we did lots of manual tests in the dev env. The reason I didn't do is that the current integration tests (excluding my change) are not stable. I will see what I can do. Thanks.
added 7 commits
-
cdc361a2...1033b737 - 6 commits from branch
master
- b3384209 - Merge from master
-
cdc361a2...1033b737 - 6 commits from branch
added 1 commit
- 3abb9565 - Ensure that createIndexAlias won't affect the creation of index
added 1 commit
- a2479b14 - Refactor the codes for creating index alias and update unit test
- Resolved by Zhibin Mai
Given
- the alias is created when the index is created in the indexer
- the current indexer test framework is creating the indices directly through elastic search API instead of through the indexer API, the alias won't be created when the index is created unless we change the way on how to create the index in the integration tests.
- the indexer has enough coverage on creating the alias from its unit tests
- the search service has integration test that creates the alias of the index on demand. It uses same kind of elastic API to create the alias as the indexer
I suggest to skip the integration test on creating the alias in the indexer.
added 6 commits
-
a2479b14...7e05ff57 - 5 commits from branch
master
- 5f6fbe1d - Merge branch 'master' of https://community.opengroup.org/osdu/platform/system/indexer-service
-
a2479b14...7e05ff57 - 5 commits from branch
@Rustam_Lotsmanenko @fhoueto.amz @Rostislav_Dublin @krveduru Please review this MR. Thanks.
Azure approved as the pipeline passed for Azure
Edited by Srinivasan Narayananmentioned in commit e32f0ab8
changed milestone to %M16 - Release 0.19
added Common Code MRBugfix labels
mentioned in merge request !484 (merged)