Skip to content
Snippets Groups Projects

Unique bucket name across GCP (GONRG-701)

Merged Riabokon Stanislav(EPAM)[GCP] requested to merge unique_backed_name_across_GCP into master

Description:

  • Fixed a bug related to getting of bucket name (Bucket name should be unique across GCP. We had to add ProjectID to the naming to fix the issue with provisioning of a new bucket)

  • Added a property 'enable.full.bucket.name'. If it is 'true', the bucket name will be tenantInfo.getProjectId() + "-" + tenantInfo.getName() + "-" + BUCKET_NAME, otherwise, tenantInfo.getName() + "-" + BUCKET_NAME. Moreover, This bucket name will be tenantInfo.getName() + "-" + BUCKET_NAME for a case related to 'enable.full.bucket.name=null'

How to test:

Check business logic.

Changes include:

  • Refactor (a non-breaking change that improves code maintainability).
  • Bugfix (a non-breaking change that solves an issue).
  • New feature (a non-breaking change that adds functionality).
  • Breaking change (a change that is not backward-compatible and/or changes current functionality).

Changes in:

  • GCP
  • Azure
  • AWS
  • IBM

Dev Checklist:

  • Added Unit Tests, wherever applicable.
  • Updated the Readme, if applicable.
  • Existing Tests pass
  • Verified functionality locally
  • Self Reviewed my code for formatting and complex business logic.

Other comments:

Any comments to approvers here

Edited by Riabokon Stanislav(EPAM)[GCP]

Merge request reports

Merge request pipeline #10294 passed

Pipeline: Legal

#10296

    Merge request pipeline passed for e88b41aa

    Deployed to G‎CP‎ 4 years ago
    Deployed to A‎WS‎ 4 years ago
    Deployed to I‎BM‎ 4 years ago

    Merged by Rostislav Dublin (EPAM)Rostislav Dublin (EPAM) 4 years ago (Sep 29, 2020 7:58am UTC)

    Loading

    Pipeline #10301 passed

    Pipeline passed for f2698b77 on master

    Deployed to G‎CP‎ 4 years ago
    Deployed to I‎BM‎ 4 years ago
    Deployed to A‎WS‎ 4 years ago

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
    Please register or sign in to reply
    Loading