Unique bucket name across GCP (GONRG-701)
Description:
-
Fixed a bug related to getting of bucket name (Bucket name should be unique across GCP. We had to add ProjectID to the naming to fix the issue with provisioning of a new bucket)
-
Added a property 'enable.full.bucket.name'. If it is 'true', the bucket name will be
tenantInfo.getProjectId() + "-" + tenantInfo.getName() + "-" + BUCKET_NAME
, otherwise,tenantInfo.getName() + "-" + BUCKET_NAME
. Moreover, This bucket name will betenantInfo.getName() + "-" + BUCKET_NAME
for a case related to 'enable.full.bucket.name=null'
How to test:
Check business logic.
Changes include:
-
Refactor (a non-breaking change that improves code maintainability). -
Bugfix (a non-breaking change that solves an issue). -
New feature (a non-breaking change that adds functionality). -
Breaking change (a change that is not backward-compatible and/or changes current functionality).
Changes in:
-
GCP -
Azure -
AWS -
IBM
Dev Checklist:
-
Added Unit Tests, wherever applicable. -
Updated the Readme, if applicable. -
Existing Tests pass -
Verified functionality locally -
Self Reviewed my code for formatting and complex business logic.
Other comments:
Any comments to approvers here
Merge request reports
Activity
added GC label
mentioned in merge request osdu/platform/system/indexer-queue!25 (merged)
added 3 commits
-
8c76d0ae...701c52d8 - 2 commits from branch
master
- 4c6077aa - Merge branch 'master' into unique_backed_name_across_GCP
-
8c76d0ae...701c52d8 - 2 commits from branch
@Stanislav_Riabokon please take a look at failed GCP tests: https://community.opengroup.org/osdu/platform/security-and-compliance/legal/-/jobs/46140
added 3 commits
-
4c6077aa...9c6ef97b - 2 commits from branch
master
- 1ede9535 - Merge branch 'master' into unique_backed_name_across_GCP
-
4c6077aa...9c6ef97b - 2 commits from branch
- Resolved by Riabokon Stanislav(EPAM)[GCP]
@Stanislav_Riabokon - the issue with test is still actual. I see that it is working in master! Please try to debug and fix it.
Edited by Dmitriy Rudko
added 11 commits
-
1ede9535...0169c1d8 - 2 commits from branch
master
- 927fa58f - https://jiraeu.epam.com/browse/GONRG-539
- d4c93d1e - GONRG-580 change the way legal get it config bucket
- 46ecd288 - Merge branch 'feature/GONRG-580-fix-legal-config' into 'integration-master'
- 07e5a9ec - Merge branch 'feature/GONRG-539_creds_for_legal' into 'integration-master'
- 054dfa3c - Merge branch 'master' into 'integration-master'
- d1c16790 - GONRG-666: add integration test's description and requirements in README file
- 4c157766 - Merge branch 'feature/GONRG-666_add_tests_description' into 'integration-master'
- 1c3c0e78 - Merge remote-tracking branch 'origin/integration-master' into unique_backed_name_across_GCP
- 71d5b478 - Merge remote-tracking branch 'community/master' into unique_backed_name_across_GCP
Toggle commit list-
1ede9535...0169c1d8 - 2 commits from branch
- Resolved by Riabokon Stanislav(EPAM)[GCP]
@Stanislav_Riabokon add default behavior to not break existing functioanlity
added 8 commits
-
71d5b478...ac3fcbd4 - 7 commits from branch
master
- d0fa8c73 - Merge branch 'master' into unique_backed_name_across_GCP
-
71d5b478...ac3fcbd4 - 7 commits from branch