Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • L Legal
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 13
    • Issues 13
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 6
    • Merge requests 6
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Open Subsurface Data Universe SoftwareOpen Subsurface Data Universe Software
  • Platform
  • Security and Compliance
  • Legal
  • Merge requests
  • !46

Unique bucket name across GCP (GONRG-701)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Riabokon Stanislav(EPAM)[GCP] requested to merge unique_backed_name_across_GCP into master Aug 28, 2020
  • Overview 13
  • Commits 6
  • Pipelines 36
  • Changes 8

Description:

  • Fixed a bug related to getting of bucket name (Bucket name should be unique across GCP. We had to add ProjectID to the naming to fix the issue with provisioning of a new bucket)

  • Added a property 'enable.full.bucket.name'. If it is 'true', the bucket name will be tenantInfo.getProjectId() + "-" + tenantInfo.getName() + "-" + BUCKET_NAME, otherwise, tenantInfo.getName() + "-" + BUCKET_NAME. Moreover, This bucket name will be tenantInfo.getName() + "-" + BUCKET_NAME for a case related to 'enable.full.bucket.name=null'

How to test:

Check business logic.

Changes include:

  • Refactor (a non-breaking change that improves code maintainability).
  • Bugfix (a non-breaking change that solves an issue).
  • New feature (a non-breaking change that adds functionality).
  • Breaking change (a change that is not backward-compatible and/or changes current functionality).

Changes in:

  • GCP
  • Azure
  • AWS
  • IBM

Dev Checklist:

  • Added Unit Tests, wherever applicable.
  • Updated the Readme, if applicable.
  • Existing Tests pass
  • Verified functionality locally
  • Self Reviewed my code for formatting and complex business logic.

Other comments:

Any comments to approvers here

Edited Sep 23, 2020 by Riabokon Stanislav(EPAM)[GCP]
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: unique_backed_name_across_GCP