extract base_app in separate module

assigned to @avincent2

marked this merge request as ready

IBM was using S2I.

Changing the image entry point needs to be communicated to them, and other CSPs

S2I = source to image (openshift)
CSP = cloud service provider

FYI @anujgupta @yochint1 lets us know if this change is fine for you. Thanks !

2 weeks now, decision was to merge it

@ashwani_pandey Could you have a look at this change/comments?

sure @kin.ng

resolved all threads

approved this merge request

approved this merge request

merged

mentioned in commit 6f94027b

Hi @avincent2 , I can see that IBM int test is failing in this MR. First I checked behind this reason for failing IBM int test and I found that error in log that is coming Error loading ASGI app. Attribute "base_app" not found in module "app.wdms_app". I also checked code which is changed in this MR and I found that you have created new module which is base.py and you are defining base_app in base.py module but After changing all these thing I can see error in log which is "Error loading ASGI app. Attribute "base_app" not found in module "app.wdms_app"." . Need your help please suggest that Do I need to change anything in configuration side regarding changes in this MR? For your reference I have attached some screenshot. and also in one file I can see that "app.wdms_app:base_app" is using in entrypoint.sh file but it is not changed in this MR:

FYI @shrikgar

HI @ashwani_pandey, Thank you for looking into this.

Indeed the base_app FastAPI instance is now accessible in the app.base module. So I think the uvicorn command should be changed to uvicorn app.base:base_app ...

On our side, we rely on the docker file, where you can see the change: https://community.opengroup.org/osdu/platform/domain-data-mgmt-services/wellbore/wellbore-domain-services/-/blob/master/build/Dockerfile#L43

@avincent2 Thank you for your input.

changed milestone to %M12 - Release 0.15