Skip to content
Snippets Groups Projects

Service Bus Implementation

Merged Nikhil Singh[MicroSoft] requested to merge users/nikhil/ServiceBusImplementation into master

All Submissions:


  • [YES] I have added an explanation of what changes in this merge do and why we should include it?
  • [NO] Does the MR contain pipeline/ helm chart related changes?
  • [NO] I have updated the documentation accordingly.
  • [N0] I have added tests to cover my changes.
  • [NA] All new and existing tests passed.
  • [YES] My code follows the code style of this project.
  • [NA] I ran lint checks locally prior to submission.

What is the issue or story related to the change?


The MR contains the implementation of Service Bus in Notification Service which allows notification service to pull the notifications from the SB. The core usage of this implementation is to remove the gateway from the notification flow.

High level design: Following are the High level design components:

1-Adapters-The adapter design pattern is used to plug in adapter for SB->NS or E->SB->NS.

2-Service Bus Implementation

3-Service Bus Topics and Subscriptions listening on fly - One Thread will be running post a configurable delay to fetch new Subscriptions.

Issue: #25 (closed)

Change details: The Thread scope DPS headers are there in order to support non request scope based usage.

Test coverage:


Does this introduce a breaking change?


  • [NO]

Pending items


Register Service will require changes to support CRUD operation for SB Subscriptions.

Reviewer request


  • Please provide an ETA when you plan to review this MR. Write a comment to decline or provide an ETA.
  • Block the MR if you feel there is less testing or no details in the MR
  • Please cover the following aspects in the MR -- Coding design: <Komal/Vishnu/Harshit> -- Backward Compatibility: <Komal/Vishnu/Harshit> -- Feature Logic: <Komal/Vishnu/Harshit>

Other information


Edited by Nikhil Singh[MicroSoft]

Merge request reports

Merge request pipeline #57828 passed with warnings

Pipeline: Notification

#57829

    Merge request pipeline passed with warnings for 4d6b15af

    Deployed to A‎WS‎ 3 years ago
    Deployed to I‎BM‎ 3 years ago
    Approval is optional

    Merged by Komal MakkarKomal Makkar 3 years ago (Aug 11, 2021 12:24pm UTC)

    Merge details

    • Changes merged into master with cfe6dcbd (commits were squashed).
    • Deleted the source branch.

    Pipeline #57892 failed

    Pipeline failed for cfe6dcbd on master

    Deployed to I‎BM‎ 3 years ago
    Deployed to A‎WS‎ 3 years ago

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
  • Komal Makkar
  • Komal Makkar
  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Nikhil Singh[MicroSoft] changed title from Service Bus Implementation -Extractors to Service Bus Implementation

    changed title from Service Bus Implementation -Extractors to Service Bus Implementation

  • Nikhil Singh[MicroSoft] changed the description

    changed the description

  • added 1 commit

    Compare with previous version

  • Komal Makkar
  • Komal Makkar
  • Komal Makkar
  • Komal Makkar
  • Komal Makkar
  • Komal Makkar
  • Komal Makkar
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading