Skip to content

Authz addition for Event Grid

Komal Makkar requested to merge users/komakkar/EventGridAuth into master

All Submissions:


  • [YES] I have added an explanation of what changes in this merge do and why we should include it?
  • [YES] Does the MR contain pipeline/ helm chart related changes?
  • [YES] I have updated the documentation accordingly.
  • [YES] I have added tests to cover my changes.
  • [YES] All new and existing tests passed.
  • [YES] My code follows the code style of this project.
  • [YES] I ran lint checks locally prior to submission.

What is the issue or story related to the change?


High level design:

Issue:

  1. #10 (closed) Authorization for pubsub is done differently. Entitlements shouldn't be called for the PubSub requests. AuthZ for Ops/ITs is done via Entitlements. This change introduces the AuthZ for PubSub.
  2. #19 (closed) This issue is partly solved. The call to tenant factory is short-circuited to make sure the circular dependency doesn't block the core update.

Change details: The AuthZ for Event Grid production flow is enabled.

Test coverage:


Does this introduce a breaking change?


  • [NO]

Pending items


#21 (closed)

Reviewer request


  • Please provide an ETA when you plan to review this MR. Write a comment to decline or provide an ETA.
  • Block the MR if you feel there is less testing or no details in the MR
  • Please cover the following aspects in the MR -- Coding design: <Reviewer1> -- Backward Compatibility: <Reviewer2> -- Feature Logic: <Logic design> -- <Any other context mention here> OR -- <Component 1>: <Reviewer1> -- <CosmosDB>: <Reviewer2> -- <ServiceBus> <Reviewer3> -- <Mention any other component and owner>

Other information


Edited by Komal Makkar

Merge request reports