Skip to content

Fix GC caching, and enable baremetal int tests.

Rustam Lotsmanenko (EPAM) requested to merge gc-fix-cache into master

Type of change

  • Bug Fix
  • Feature

Please provide link to gitlab issue or ADR(Architecture Decision Record)

Does this introduce a change in the core logic?

  • [NO]

Does this introduce a change in the cloud provider implementation, if so which cloud?

  • AWS
  • Azure
  • Google Cloud
  • IBM

Does this introduce a breaking change?

  • [NO]

What is the current behavior?

  • Baremetal tests are not enabled.
  • Caching is error-prone and values are stored incorrectly, using as a key partition ID and as a values list of all subscriptions, update and write can collide:
{
	"osdu": [
		{
			"subId": "1",
			"topic": "topic name",
			"secret": "****"
		},
		{
			"subId": "2",
			"topic": "topic name",
			"secret": "****"
		}
		...etc
	]
}

What is the new/expected behavior?

  • Baremetal tests are enabled.
  • Added Spring Redis Data, to use RedisTemplate and SCAN commands, which are not available in standard OSDU Redis client.
  • Cached values are decoupled, each subscription are individual records now, and updates and write won't collide:
[
	{
		"subId": "osdu-topic-name-1",
		"topic": "topic name",
		"secret": "****"
	},
	{
		"subId": "osdu-topic-name-2",
		"topic": "topic name",
		"secret": "****"
	}
        ...etc
]

Have you added/updated Unit Tests and Integration Tests?

Yes

Edited by Rustam Lotsmanenko (EPAM)

Merge request reports