Core change: Adding case for handshake request header creation (!33) · Merge requests · OSDU Software / OSDU Data Platform / System / Notification · GitLab

Starting on April 8th, The Open Group will require Two Factor Authentication for all GitLab users. For instructions on setting up 2FA, see the Knowledge Article or GitLab Documentation. Note in particular that any HTTPS clones will require the use of a Personal Access Token (rather than a user’s password) once 2FA is enabled.

Komal Makkar requested to merge users/komakkar/handshakehandlerrequestheader into master Nov 02, 2020

Type of change

Bug Fix
Feature

Please provide link to gitlab issue or ADR(Architecture Decision Record)
#16 (closed)

Does this introduce a change in the core logic?

[YES/NO] YES

Does this introduce a change in the cloud provider implementation, if so which cloud?

AWS
Azure
GCP
IBM

Does this introduce a breaking change?

[YES/NO] No

What is the current behavior?

Header gets formed for handshake requests, which do not carry relevant information

What is the new/expected behavior?

Header should not have information like partition id etc.

Have you added/updated Unit Tests and Integration Tests?

Yes

Any other useful information

Edited Nov 05, 2020 by Komal Makkar