Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • N Notification
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 12
    • Merge requests 12
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Open Subsurface Data Universe SoftwareOpen Subsurface Data Universe Software
  • Platform
  • System
  • Notification
  • Merge requests
  • !3

Notification Service Azure Provider Changes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Komal Makkar requested to merge service_account_accesstoken_generation into master Jul 28, 2020
  • Overview 65
  • Commits 27
  • Pipelines 19
  • Changes 21

Description

The changes for Azure provider implementation for Notification service.

  • Functionally, the AAD JWT token generation is facilitated by the changes.
  • Caching of jwt token, tenant etc are added.
  • All DIs are done for the interfaces in notification-core.

Closes issue(s)

  • Partially closes (issue)[#3 (closed)]

The changes that are planned for the same issue/feature, in different MRs.

  • The PubSub Authentication will be a different MR and is marked as TODO as of now
  • Role-based auth, basic authZ, and AuthZ (securityConfig) is to be added.

How to test / repro

  • Deploy the services locally run integration Tests

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • Added Unit Tests, wherever applicable.
  • Updated the Readme
  • Existing Tests pass
  • Verified functionality locally
  • Self Reviewed my code for formatting and complex business logic.

Other comments

  • Data partitioning in azure cosmos DB: currently data from all the tenants are being stored in a single cosmos DB instance, partitioned by the dataPartitionId of that tenant. This model might change in the future, and the changes will follow in the Notification Service.
  • Integration test config requires refactoring in the notification-core. The IT for notification-azure will consumable post that.

FYI @dkodeih @danielscholl

Edited Aug 12, 2020 by Komal Makkar
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: service_account_accesstoken_generation