Fixed exceptions
Type of change
-
Bug Fix -
Feature
Please provide link to gitlab issue or ADR(Architecture Decision Record)
Does this introduce a change in the core logic?
- [YES/NO] NO
Does this introduce a change in the cloud provider implementation, if so which cloud?
-
AWS -
Azure -
GCP -
IBM
Does this introduce a breaking change?
- [YES/NO] NO
What is the current behavior?
What is the new/expected behavior?
Have you added/updated Unit Tests and Integration Tests?
Any other useful information
Edited by Sanjeev-SLB
Merge request reports
Activity
requested review from @SmithaManjunath
assigned to @spellikoduku
added 6 commits
-
a07ffcd8...5d989c5e - 5 commits from branch
master - 3f2de07a - Merge branch 'master' of...
-
a07ffcd8...5d989c5e - 5 commits from branch
requested review from @sasarava
86 86 LOGGER.info("Message delivery status is 'Abandon' with notificationId: {}, Count: {}", notificationContent.getNotificationId(), message.getDeliveryCount()); Hi @spellikoduku , please explain the need of this if else block? What use case does it solve? Why number 8 has been hard coded here?
The else block is to suppress internal client push endpoint errors, removed to keep generic code.
Edited by Sanjeev-SLBchanged this line in version 4 of the diff
86 86 LOGGER.info("Message delivery status is 'Abandon' with notificationId: {}, Count: {}", notificationContent.getNotificationId(), message.getDeliveryCount()); 87 87 } else { 88 88 LOGGER.error(NOT_ACKNOWLEDGE); 89 throw new Exception(NOT_ACKNOWLEDGE); Hi @spellikoduku , please provide a reason why this throw statement is being removed.
@sasarava Implemented same as Notification V1, the not acknowledge events supposed to throw an error.
added 4 commits
-
20cde545...83a4bcfe - 2 commits from branch
master - 32c20cfc - Merge branch 'master' of...
- 88cf1a57 - Fixed exception error
-
20cde545...83a4bcfe - 2 commits from branch
added 3 commits
-
27792468...83b2389b - 2 commits from branch
master - 7673dd9f - Merge branch 'master' of...
-
27792468...83b2389b - 2 commits from branch
mentioned in commit b038451f
Please register or sign in to reply