MR suggestions

notification-core/src/main/java/org/opengroup/osdu/notification/auth/AuthorizationFilter.java

@@ -94,8 +94,9 @@ public class AuthorizationFilter {
     }
 
     private boolean authorizeWithCache(String[] requiredRoles, Groups groups) {
-        if(groups.any(requiredRoles))
+        if(groups.any(requiredRoles)) {
             return true;
+        }
         return false;
     }
 

notification-core/src/main/java/org/opengroup/osdu/notification/di/GroupVmCache.java

-// Copyright 2017-2024, SLB
+// Copyright 2017-2025, SLB
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.

notification-core/src/main/java/org/opengroup/osdu/notification/utils/MathUtils.java

-// Copyright 2017-2024, SLB
+// Copyright 2017-2025, SLB
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -22,6 +22,10 @@ public class MathUtils {
      */
     public static int generateRandomNumberBetweenBounds(int lower, int upper) {
         Random random = new Random();
-        return random.nextInt(upper - lower) + lower;
+        if (upper > lower) {
+            return random.nextInt(upper - lower) + lower;
+        } else {
+            return random.nextInt(lower - upper) + upper;
+        }
     }
 }

notification-core/src/test/java/org/opengroup/osdu/notification/auth/AuthorizationFilterTest.java

@@ -94,7 +94,6 @@ public class AuthorizationFilterTest {
         final String USER_EMAIL = "test@test.com";
         AuthorizationResponse authorizationResponse = AuthorizationResponse.builder().user(USER_EMAIL).build();
         when(this.authorizationService.authorizeAny(any(), eq(ROLE1), eq(ROLE2))).thenReturn(authorizationResponse);
-        //when(this.groupVmCache.get("8Z2MjQ==")).thenReturn(null);
 
         assertTrue(this.sut.hasAnyPermission(ROLE1, ROLE2));
         verify(headers).put(DpsHeaders.USER_EMAIL, "test@test.com");