Skip to content

EG Topic Abstraction

Komal Makkar requested to merge users/komakkar/eventGridAbstraction into master

All Submissions:


  • [YES] I have added an explanation of what changes in this merge do and why we should include it?
  • [NO] Does the MR contain pipeline/ helm chart related changes?
  • [YES] I have updated the documentation accordingly.
  • [YES] I have added tests to cover my changes.
  • [YES] All new and existing tests passed.
  • [YES] My code follows the code style of this project.
  • [YES] I ran lint checks locally prior to submission.

What is the issue or story related to the change?


High level design:

Event Grid Abstraction is done here for Topics. ATM, it is being consumed by Storage service.

Issue:

Change details:

Test coverage:


image

Does this introduce a breaking change?


  • [NO]

Pending items


Event Grid Subscriber changes are supposed to be a part of the partition effort driven by SLB.

Reviewer request


  • Please provide an ETA when you plan to review this MR. Write a comment to decline or provide an ETA.
  • Block the MR if you feel there is less testing or no details in the MR
  • Please cover the following aspects in the MR -- Coding design: <Reviewer1> -- Backward Compatibility: <Reviewer2> -- Feature Logic: <Logic design> -- <Any other context mention here> OR -- <Component 1>: <Reviewer1> -- <CosmosDB>: <Reviewer2> -- <ServiceBus> <Reviewer3> -- <Mention any other component and owner>

Other information


Edited by Komal Makkar

Merge request reports

Loading