Fix mapping boolean values to string
As reported in #182 boolean values are mapped into string values due to wrong mapping being created for them and changes in autocasting mechanism started cast those values to the type of mapping. Changes here are changing mapping created to the right type. This MR requires reindexing with the force clean or other kind manipulation on the index as field types are being changed. Changes are on the schema parser level so if there are other methods of adding field to index schema they should be also checked if they use boolean instead of bool as boolean is valid storage type. Reindexing is important especially for indexes which are using copy_to mechanics or similar (like those where bag of words are enabled) as they don't allow invalid types to be added to string indices.
Merge request reports
Activity
requested review from @nthakur
added 7 commits
-
b8aac020...a3dcd6ea - 6 commits from branch
master - eb33b04e - Fix mapping boolean values to string
-
b8aac020...a3dcd6ea - 6 commits from branch
changed milestone to %M25 - Release 0.28
Tagging @jordanchiu, @ashley_beitz, @ladatz for MS review
changed milestone to %M24 - Release 0.27
added MRBugfix label
added Common Code label
changed milestone to %M25 - Release 0.28
mentioned in issue #182
added 20 commits
-
7f935975...dc6ed7e6 - 19 commits from branch
master - 18d5ac4c - Merge branch 'master' into fix/use-right-mapping-for-booleans
-
7f935975...dc6ed7e6 - 19 commits from branch
added 12 commits
-
1b295b20...e9d543fc - 11 commits from branch
master - c311937a - Merge branch 'master' into fix/use-right-mapping-for-booleans
-
1b295b20...e9d543fc - 11 commits from branch
requested review from @zmai
The changes made by @sbstan have been put behind a feature flag and the unit tests updated accordingly.
