Skip to content
Snippets Groups Projects

Gcp full reindex (GONRG-1534)

Merged Rustam Lotsmanenko (EPAM) requested to merge gcp-full-reindex into master
1 unresolved thread

Description:

As a part of the migration to a new Elastic 7 we need some functionality
that will allow us to do full reindex of Records registered in Storage service.
Added new endpoint: PATCH /api/indexer/v2/reindex?force_clean=false

  • Get all kind from Storage
  • Clean all old indexes in Elastic
  • Iterate over kinds and do reindex

How to test:

Functionality was tested locally, with local elastic(v6 & v7)

Changes include:

  • Refactor (a non-breaking change that improves code maintainability).
  • Bugfix (a non-breaking change that solves an issue).
  • New feature (a non-breaking change that adds functionality).
  • Breaking change (a change that is not backward-compatible and/or changes current functionality).

Changes in:

  • GCP
  • Azure
  • AWS
  • IBM

Dev Checklist:

  • Existing Tests pass
  • Verified functionality locally
  • Self Reviewed my code for formatting and complex business logic.

Other comments:

Functionality was implemented with reusing existing logic for reindex of a single kind, to reduce common code changes, thus due to architectural features, request cannot be executed asynchronously, and response may be detained.

Edited by Rustam Lotsmanenko (EPAM)

Merge request reports

Merge request pipeline #23599 failed

Pipeline: Indexer

#23600

    Merge request pipeline failed for 9e0358db

    Deployed to A‎WS‎ 4 years ago
    Deployed to I‎BM‎ 4 years ago
    Approved by

    All merge request dependencies have been merged (2 merged)

    Merged by Dmitriy RudkoDmitriy Rudko 4 years ago (Feb 1, 2021 5:01pm UTC)

    Merge details

    • Changes merged into master with af0d36ee.
    • Deleted the source branch.

    Pipeline #24289 failed

    Pipeline failed for af0d36ee on master

    Skipped deployment to G‎CP‎
    Deployed to I‎BM‎ 4 years ago
    Failed to deploy to A‎WS‎

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
  • added 4 commits

    Compare with previous version

    • @osdu/platform/roles/ibm-contributors
    • @osdu/platform/roles/gcp-contributors
    • @osdu/platform/roles/aws-contributors
    • @osdu/platform/roles/azure-contributors Dear colleagues pls review/approve this MR. We need at least 2 more approves because it relates common parts.
  • @osdu/platform/roles/ibm-contributors pls fix IBM tests

  • @bhushanrade @shrikgar Please check this

  • @anujgupta, @bhushanrade, @shrikgar - It looks like that IBM tests are failing in master as well. Don't you mind if we will merge this change?

  • Rostislav Dublin (EPAM) approved this merge request

    approved this merge request

  • @osdu/platform/roles/trusted-committers GCP IBM Azure AWS: this MR changes common codebase, pls review/approve.

  • Dmitriy Rudko approved this merge request

    approved this merge request

  • Matt Wise approved this merge request

    approved this merge request

  • Dmitriy Rudko mentioned in commit af0d36ee

    mentioned in commit af0d36ee

  • merged

  • changed milestone to %M3 - Release 0.5

  • Please register or sign in to reply
    Loading