Skip to content
Snippets Groups Projects

Resolve duplicate index PropertyConfigurations by choosing the last modify one

Merged Zhibin Mai requested to merge resolve_duplicate_propertyconfigurations into master
All threads resolved!

In current implementation of the index Augmenter, there is no ideal mechanism to merge duplicate Index PropertyConfiguratons for given kind. It can only pick one. And we can't prevent users from creating duplicate Index PropertyConfiguratons (using same code but different record id) using the Storage Service API.

In the latest pre-ship test of index augmenter, a user created duplicate Index PropertyConfiguratons by mistake and forgot that a duplicate Index PropertyConfiguratons record was created. No matter how the user changed the new one, the Index Augmenter did not take effect on the new one. User had no idea what happened as the new configuration is correct.

We found that it could be a common problem, especially for users who are not aware of the limitation - no conflict/merge strategy is applied on duplicate Index PropertyConfiguations.

Before we can come out better strategy to deal with duplicate Index PropertyConfiguratons, we change the augmenter to pick the last modified one if there are more than one Index PropertyConfiguarations for a given kind and log a warning message. The change is simple and should be safe.

Merge request reports

Merge request pipeline #201685 failed

Pipeline: Indexer

#201686

    Merge request pipeline failed for a56d6f1c

    Failed to deploy to A‎WS‎
    Deployed to I‎BM‎ 1 year ago
    Failed to deploy to Google‎_Cloud‎

    Merged by Zhibin MaiZhibin Mai 1 year ago (Aug 1, 2023 3:34pm UTC)

    Loading

    Pipeline #202128 failed

    Pipeline failed for 12709b53 on master

    Failed to deploy to Google‎_Cloud‎
    Deployed to A‎WS‎ 1 year ago
    Skipped deployment to I‎BM‎

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
  • Zhibin Mai resolved all threads

    resolved all threads

  • Srinivasan Narayanan approved this merge request

    approved this merge request

  • Azure pipeline looks green. Approved.

  • Zhibin Mai resolved all threads

    resolved all threads

  • Zhibin Mai resolved all threads

    resolved all threads

  • Zhibin Mai resolved all threads

    resolved all threads

  • Rustam Lotsmanenko (EPAM) approved this merge request

    approved this merge request

  • Zhibin Mai mentioned in commit 12709b53

    mentioned in commit 12709b53

  • merged

  • Please register or sign in to reply
    Loading