Fixed upsert method in reference module (GONRG-3573)

All Submissions:

---

• [YES/NO] I have added an explanation of what changes in this merge do and why we should include it?
• [YES/NO] I have updated the documentation accordingly.
• [NA] I have added tests to cover my changes.
• [YES] All new and existing tests passed.
• [YES] My code follows the code style of this project.
• [YES] I ran lint checks locally prior to submission.

What is the current behavior?

---

Issue: Remember to link the workitem to this pull request. The item creation is using save method of MongoDB. It is identical with upsert, thus, we could overwrite data in existed item by accident.

What is the new behavior?

---

The item creation is using insert method. The existed item will not be overwritten by creation of the clone, there will be an error instead

Does this introduce a breaking change?

---

• [NO]

Any relevant logs, error output, etc?

---

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Other information

---

provider/legal-reference/src/main/java/org/opengroup/osdu/legal/tags/dataaccess/MongoLegalTagRepository.java

@@ -35,6 +35,7 @@ import org.opengroup.osdu.legal.config.MongoDBConfigProperties;
 import org.opengroup.osdu.legal.entity.LegalTagMongoEntity;
 import org.opengroup.osdu.legal.provider.interfaces.ILegalTagRepository;
 import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.dao.DuplicateKeyException;
 import org.springframework.data.mongodb.core.MongoOperations;
 import org.springframework.data.mongodb.core.query.Criteria;
 import org.springframework.data.mongodb.core.query.Query;
@@ -59,7 +60,15 @@ public class MongoLegalTagRepository implements ILegalTagRepository {
 
     MongoOperations ops = clientProvider.getOps(mongoDBConfigProperties.getMongoDbName());
 
-    LegalTagMongoEntity savedEntity = ops.save(convertFrom(legalTag), LEGAL_TAGS_ENTITYNAME);
+    LegalTagMongoEntity savedEntity = null;
+
+    try {
+      savedEntity = ops.insert(convertFrom(legalTag), LEGAL_TAGS_ENTITYNAME);
+    } catch (DuplicateKeyException ex){
+      throw new AppException(409, "Legal tag conflict", String.format(
+              "A LegalTag already exists for the given name %s. Can't create again. Id is %s",
+              legalTag.getName(), legalTag.getId()));
+    }
 
     return savedEntity.getId();
   }