Skip to content
Snippets Groups Projects

Implement Storage service send notification for deleted versions of a record

Merged Wesley Evans requested to merge wbevans/purge-version-notification into master

Type of change

  • Bug Fix
  • Feature

Please provide link to gitlab issue or ADR(Architecture Decision Record)
#252

Does this introduce a change in the core logic?

  • Yes

Does this introduce a change in the cloud provider implementation, if so which cloud?

  • AWS
  • Azure
  • GCP
  • IBM

Does this introduce a breaking change?

  • No

What is the current behavior?

When a record is created/updated/deleted using storage service, there is notification that is sent, For instance in case of Azure a message is published in recordstopic. There are down stream services that subscribe to recordstopic and react to notification sent by storage service in case of create/update/delete event. For instance, downstream services stores Technical Assurance information for each version of record, which help user to understand and provide trust and assurance of data stored using storage service. Storage API provides endpoint delete record versions - https://community.opengroup.org/osdu/platform/system/storage/-/blob/master/storage-core/src/main/java/org/opengroup/osdu/storage/api/RecordApi.java?ref_type=heads#L177 which permanently deletes versions of record.

Storage service endpoint "delete record versions" does not send any notification to recordstopic and hence downstream service cannot react to this event. This could create issue in downstream services and provide inconsistent data.

What is the new/expected behavior?

Storage service endpoint "delete record versions" now sends notification to recordstopic for deleted record versions

Have you added/updated Unit Tests and Integration Tests?

Yes, created new unit tests

Any other useful information

Screenshot of resulting notifications sent for deletion of record versions: Screenshot_2025-01-29_120443

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • A few suggestions.

  • Ashley Beitz approved this merge request

    approved this merge request

  • Wesley Evans added 1 commit

    added 1 commit

    • d3449495 - Added check for splitting versionPath string

    Compare with previous version

  • Wesley Evans reset approvals from @dacarpen and @ashley_beitz by pushing to the branch

    reset approvals from @dacarpen and @ashley_beitz by pushing to the branch

  • Wesley Evans resolved all threads

    resolved all threads

  • Wesley Evans requested review from @dacarpen

    requested review from @dacarpen

  • Wesley Evans requested review from @ashley_beitz

    requested review from @ashley_beitz

  • Ashley Beitz approved this merge request

    approved this merge request

  • Daniel Carpenter
  • Ashley Beitz unapproved this merge request

    unapproved this merge request

  • Ashley Beitz resolved all threads

    resolved all threads

  • Wesley Evans added 1 commit

    added 1 commit

    • 87ebaa01 - Added logging when token size is off

    Compare with previous version

  • Wesley Evans resolved all threads

    resolved all threads

  • Ashley Beitz approved this merge request

    approved this merge request

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading