Skip to content
Snippets Groups Projects

Added a fix to the AWS Delete API returning 500 errors when the record doesn't exist

Merged Added a fix to the AWS Delete API returning 500 errors when the record doesn't exist
aws-fix-delete into master
All threads resolved!
Merged Derek Hudson requested to merge aws-fix-delete into master
All threads resolved!

Type of change

  • Bug Fix
  • Feature

Please provide link to gitlab issue or ADR(Architecture Decision Record)

Does this introduce a change in the core logic?

  • [NO]

Does this introduce a change in the cloud provider implementation, if so which cloud?

  • AWS
  • Azure
  • GCP
  • IBM

Does this introduce a breaking change?

  • [NO]

What is the current behavior?

Storage delete on AWS will return with 500 error codes when the record doesn't exist. It will no longer do this. Also, instead of only deleting the legal tags associations with the record at time of deletion, it will delete all of the legal tag associations with that record id.

What is the new/expected behavior?

Storage delete should not return with 500 error codes when the record doesn't exist.

Have you added/updated Unit Tests and Integration Tests?

Any other useful information

Merge request reports

Merge request pipeline #286060 failed

Stage: review
Stage: build
Stage: publish
Stage: deploy
Pipeline: Storage

#286061

    Merge request pipeline failed for 27e98f13

    6 environments impacted.
    Approval is optional

    Merged by Derek HudsonDerek Hudson 6 months ago (Oct 1, 2024 9:30pm UTC)

    Merge details

    • Changes merged into with 238f1378.
    • Deleted the source branch.

    Pipeline #287141 failed

    Stage: build
    Stage: coverage
    Stage: containerize
    Stage: scan
    Stage: deploy
    Stage: integration
    Stage: publish

    Pipeline failed for 238f1378 on master

    9 environments impacted.

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
  • Solomon Ayalew
  • Derek Hudson resolved all threads

    resolved all threads

  • Yunhua Koglin approved this merge request

    approved this merge request

  • Marc Burnie [AWS] approved this merge request

    approved this merge request

  • Derek Hudson resolved all threads

    resolved all threads

  • Derek Hudson merged

    merged

  • Derek Hudson mentioned in commit 238f1378

    mentioned in commit 238f1378

    • Please register or sign in to reply