Skip to content
Snippets Groups Projects

Fixes silent errors for certain cases where S3 service is down or request rate is too high.

Merged Derek Hudson requested to merge aws-fix-silent-errors into master

Type of change

  • Bug Fix
  • Feature

Please provide link to gitlab issue or ADR(Architecture Decision Record)

Does this introduce a change in the core logic?

  • [NO]

Does this introduce a change in the cloud provider implementation, if so which cloud?

  • AWS
  • Azure
  • GCP
  • IBM

Does this introduce a breaking change?

  • [NO]

What is the current behavior?

When the AWS CloudStorageImpl encounters an error with the internal service, the service will not respond with an error, but instead indicate that the records were correctly ingested.

What is the new/expected behavior?

When the AWS CloudStorageImpl encounters an error with the internal service, the service should respond with an error indicating that the record(s) could not be ingested.

Have you added/updated Unit Tests and Integration Tests?

Added Unit tests, but integration tests are not feasible as this requires a lot more data to be ingested than will typically happen during an integration test.

Any other useful information

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading