Skip to content
Snippets Groups Projects

query_with_cursor causing internal server error if kind is empty or does not exist

Merged query_with_cursor causing internal server error if kind is empty or does not exist
fix-cursor-query into master
All threads resolved!
Merged Rustam Lotsmanenko (EPAM) requested to merge fix-cursor-query into master
All threads resolved!

Type of change

  • Bug Fix
  • Feature

Please provide link to gitlab issue or ADR(Architecture Decision Record)

#313

Does this introduce a change in the core logic?

  • [YES]

Does this introduce a change in the cloud provider implementation, if so which cloud?

  • Common code

Does this introduce a breaking change?

  • [NO]

What is the current behavior?

  1. query_with_cursor could cause an internal server error with subsequent requests if the kind does not exist.

check

if (results != null)

is always true, even when there is no result, the code that should be executed and return the null cursor is never reached.

  1. Tests for the Search service cursor query were insufficient to cover this scenario.

What is the new/expected behavior?

  1. query_with_cursor returning null cursor if there were no values.
  2. Tests are covering such scenarios.

Have you added/updated Unit Tests and Integration Tests?

Yes

Any other useful information

Edited by Rustam Lotsmanenko (EPAM)

Merge request reports

Merge request pipeline #302041 failed

Stage: review
Stage: build
Stage: publish
Stage: deploy
Pipeline: Search

#302042

    Merge request pipeline failed for 701c0325

    5 environments impacted.
    Approved by
    Ashley Beitz Shane Hutchins Daniel Scholl (MS]

    Merged by Rustam Lotsmanenko (EPAM)Rustam Lotsmanenko (EPAM) 3 months ago (Jan 15, 2025 8:37am UTC)

    Merge details

    • Changes merged into master with f2b70334 (commits were squashed).
    • Deleted the source branch.

    • Mentions issue #313

    Pipeline #302584 failed

    Stage: build
    Stage: coverage
    Stage: containerize
    Stage: scan
    Stage: deploy
    Stage: integration
    Stage: publish

    Pipeline failed for f2b70334 on master

    9 environments impacted.

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
  • Ashley Beitz
  • Rustam Lotsmanenko (EPAM) added 1 commit

    added 1 commit

    Compare with previous version

  • Rustam Lotsmanenko (EPAM) reset approvals from @danielscholl and @ajoshi19 by pushing to the branch

    reset approvals from @danielscholl and @ajoshi19 by pushing to the branch

  • Rustam Lotsmanenko (EPAM) added 1 commit

    added 1 commit

    Compare with previous version

  • Daniel Scholl (MS] approved this merge request

    approved this merge request

  • Shane Hutchins approved this merge request

    approved this merge request

  • Ashley Beitz approved this merge request

    approved this merge request

  • Ashley Beitz resolved all threads

    resolved all threads

  • Rustam Lotsmanenko (EPAM) mentioned in commit f2b70334

    mentioned in commit f2b70334

  • Rustam Lotsmanenko (EPAM) merged

    merged

    • Please register or sign in to reply