Skip to content
Snippets Groups Projects

Add records topic v2 behind feature flag

Merged Anfal Fadhil requested to merge azure-partition-feature-flag into master

Type of change

  • Bug Fix
  • Feature

Please provide link to gitlab issue or ADR(Architecture Decision Record) This ADR might be helpful.

Does this introduce a change in the core logic?

  • [NO]

Does this introduce a change in the cloud provider implementation, if so which cloud?

  • AWS
  • Azure
  • Google Cloud
  • IBM

Does this introduce a breaking change?

  • [NO]

What is the current behavior?

Register is not using partition specific feature flag.

What is the new/expected behavior?

Using partition specific feature flag to make the service gradually collaboration aware.

Have you added/updated Unit Tests and Integration Tests?

yes

Any other useful information

Merge request reports

Merge request pipeline #161397 failed

Pipeline: Register

#161398

    Merge request pipeline failed for e9711094

    Merged by ashley kelhamashley kelham 2 years ago (Jan 23, 2023 9:41pm UTC)

    Loading

    Pipeline #161404 passed with warnings

    Pipeline passed with warnings for 4f82f0ab on master

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
  • ashley kelham
  • ashley kelham changed title from partition feature flag added to Add records topic v2 behind feature flag

    changed title from partition feature flag added to Add records topic v2 behind feature flag

  • Anfal Fadhil resolved all threads

    resolved all threads

  • Anfal Fadhil added 1 commit

    added 1 commit

    • 13b9f986 - added a cache to topicsMap, reverted the topics file in test and updated the tests

    Compare with previous version

  • Anfal Fadhil added 1 commit

    added 1 commit

    • e5669701 - updated to check for the flag every time a request come

    Compare with previous version

  • Anfal Fadhil added 1 commit

    added 1 commit

    Compare with previous version

  • 57 57 "recordIdVersion": "1610537924768407",
    58 58 "stage": "STORAGE_SYNC",
    59 59 "status": "FAILED",
    60 "message": "acl is not valid",
  • Anfal Fadhil added 1 commit

    added 1 commit

    • bc1a7ef0 - returning a new updated list according to the condtions

    Compare with previous version

  • Anfal Fadhil added 1 commit

    added 1 commit

    Compare with previous version

  • Srinivasan Narayanan approved this merge request

    approved this merge request

  • added Azure label

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading