Skip to content
Snippets Groups Projects

Adding logic to handle failure scenario during Create Subscription

Merged Adding logic to handle failure scenario during Create Subscription
haaggarw/HandlingFailureScenarioDuringCreateSubscription into master
All threads resolved!
Merged harshit aggarwal requested to merge haaggarw/HandlingFailureScenarioDuringCreateSubscription into master
All threads resolved!

This PR Contains

  1. logic to handle failure scenario during Create Subscription

Scenario: While creating a new Subscription, Push Subscription creation might fail on event Grid which required the corresponding record to be deleted from Cosmos Db. Failures during this delete operation blocks a user to create a subscription with same topic and PushEndpoint combination again

  1. Added UT's to cover new changes
  2. Ran Integration Tests on local environment
  3. UT coverage is over 90%
Edited by harshit aggarwal

Merge request reports

Merge request pipeline #6629 passed

Stage: review
Pipeline: Register

#6634

    Merge request pipeline passed for b5414094

    Approved by
    Kishore Battula

    Merged by Kishore BattulaKishore Battula 4 years ago (Aug 27, 2020 7:40am UTC)

    Loading

    Pipeline #6637 failed

    Stage: build
    Stage: scan
    Stage: attribution

    Pipeline failed for 34ba592b on master

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
  • Kishore Battula
  • harshit aggarwal added 1 commit

    added 1 commit

    Compare with previous version

  • harshit aggarwal resolved all threads

    resolved all threads

  • harshit aggarwal added 1 commit

    added 1 commit

    Compare with previous version

  • Kishore Battula approved this merge request

    approved this merge request

  • Kishore Battula enabled an automatic merge when the pipeline for b5414094 succeeds

    enabled an automatic merge when the pipeline for b5414094 succeeds

  • Kishore Battula mentioned in commit 34ba592b

    mentioned in commit 34ba592b

  • Kishore Battula merged

    merged

  • Chad Leong added Azure label

    added Azure label

  • Chad Leong changed milestone to %M1 - Release 0.1

    changed milestone to %M1 - Release 0.1

    • Please register or sign in to reply