Skip to content
Snippets Groups Projects

Logging Enhancements for GCP modules (GONRG-1735, GONRG-1781)

Merged Anastasiia Gelmut requested to merge gcp-logging-enhancements into master
2 unresolved threads

Type of change

  • Bug Fix
  • Feature

Some enhancements for GCP logging system. Supplies the logs with user id, data-partition-id and correlation id https://gitlab.opengroup.org/osdu/subcommittees/ea/projects/pre-shipping/home/-/issues/50 https://gitlab.opengroup.org/osdu/subcommittees/ea/projects/pre-shipping/home/-/issues/49

Does this introduce a change in the core logic?

  • [NO]

Does this introduce a change in the cloud provider implementation, if so which cloud?

  • AWS
  • Azure
  • GCP
  • IBM

Does this introduce a breaking change?

  • [NO]

What is the current behavior?

The logs are printed in an unparseable inline format.

What is the new/expected behavior?

The logs are printed in JSON format and compatible with GCP Logger.

Have you added/updated Unit Tests and Integration Tests?

No, since it is not required for these changes

Any other useful information

There are two types of logging: for local Spring profile (spring.profiles.active=local) and for any other, incl. default. This was done for better readability while testing locally.

The MR should be merged after osdu/platform/system/lib/cloud/gcp/os-core-lib-gcp!10 (merged)

Merge request reports

Merge request pipeline #27648 passed

Pipeline: Partition

#27649

    Merge request pipeline passed for 27e17a95

    Deployed to A‎WS‎ 4 years ago
    Deployed to I‎BM‎ 4 years ago
    Approval is optional

    Merged by Riabokon Stanislav(EPAM)[GCP]Riabokon Stanislav(EPAM)[GCP] 4 years ago (Feb 20, 2021 1:39pm UTC)

    Merge details

    • Changes merged into master with adf10f2c.
    • Deleted the source branch.

    Pipeline #27654 passed

    Pipeline passed for adf10f2c on master

    Deployed to I‎BM‎ 4 years ago
    Failed to deploy to A‎WS‎

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
    2 Copyright 2002-2021 Google LLC
    3 Copyright 2002-2021 EPAM Systems, Inc
    4
    5 Licensed under the Apache License, Version 2.0 (the "License");
    6 you may not use this file except in compliance with the License.
    7 You may obtain a copy of the License at
    8
    9 http://www.apache.org/licenses/LICENSE-2.0
    10
    11 Unless required by applicable law or agreed to in writing, software
    12 distributed under the License is distributed on an "AS IS" BASIS,
    13 WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    14 See the License for the specific language governing permissions and
    15 limitations under the License.
    16 */
    17
  • 1 1 package org.opengroup.osdu.partition.logging;
  • added 1 commit

    • 27e17a95 - GONRG-1781 Added logback.xml and updated pom

    Compare with previous version

  • mentioned in commit adf10f2c

  • changed milestone to %M4 - Release 0.7

  • Please register or sign in to reply
    Loading