Skip to content
Snippets Groups Projects
Commit 16535628 authored by Yurii Ruban [EPAM / GCP]'s avatar Yurii Ruban [EPAM / GCP]
Browse files

Updated gson factory

parent f01b9e0e
No related branches found
No related tags found
1 merge request!396Upgrade First Party Library Dependencies for Release 0.21
Pipeline #189488 failed
...@@ -18,7 +18,7 @@ package org.opengroup.osdu.notification.provider.gcp.security; ...@@ -18,7 +18,7 @@ package org.opengroup.osdu.notification.provider.gcp.security;
import com.google.api.client.googleapis.auth.oauth2.GoogleIdTokenVerifier; import com.google.api.client.googleapis.auth.oauth2.GoogleIdTokenVerifier;
import com.google.api.client.http.javanet.NetHttpTransport; import com.google.api.client.http.javanet.NetHttpTransport;
import com.google.api.client.json.jackson2.JacksonFactory; import com.google.api.client.json.gson.GsonFactory;
import org.springframework.stereotype.Component; import org.springframework.stereotype.Component;
import java.util.Arrays; import java.util.Arrays;
...@@ -26,7 +26,7 @@ import java.util.Arrays; ...@@ -26,7 +26,7 @@ import java.util.Arrays;
@Component @Component
public class GoogleServiceAccountValidatorGenerator { public class GoogleServiceAccountValidatorGenerator {
public GoogleIdTokenVerifier getVerifier(NetHttpTransport transport, JacksonFactory factory, String... googleAudiences) { public GoogleIdTokenVerifier getVerifier(NetHttpTransport transport, GsonFactory factory, String... googleAudiences) {
GoogleIdTokenVerifier verifier; GoogleIdTokenVerifier verifier;
if (googleAudiences == null || googleAudiences.length == 0) { if (googleAudiences == null || googleAudiences.length == 0) {
verifier = new GoogleIdTokenVerifier.Builder(transport, factory) verifier = new GoogleIdTokenVerifier.Builder(transport, factory)
......
...@@ -19,7 +19,7 @@ package org.opengroup.osdu.notification.provider.gcp.security; ...@@ -19,7 +19,7 @@ package org.opengroup.osdu.notification.provider.gcp.security;
import com.google.api.client.googleapis.auth.oauth2.GoogleIdToken; import com.google.api.client.googleapis.auth.oauth2.GoogleIdToken;
import com.google.api.client.googleapis.auth.oauth2.GoogleIdTokenVerifier; import com.google.api.client.googleapis.auth.oauth2.GoogleIdTokenVerifier;
import com.google.api.client.http.javanet.NetHttpTransport; import com.google.api.client.http.javanet.NetHttpTransport;
import com.google.api.client.json.jackson2.JacksonFactory; import com.google.api.client.json.gson.GsonFactory;
import org.opengroup.osdu.core.common.logging.JaxRsDpsLog; import org.opengroup.osdu.core.common.logging.JaxRsDpsLog;
import org.opengroup.osdu.notification.provider.gcp.config.AppProperties; import org.opengroup.osdu.notification.provider.gcp.config.AppProperties;
import org.opengroup.osdu.notification.provider.interfaces.IServiceAccountValidator; import org.opengroup.osdu.notification.provider.interfaces.IServiceAccountValidator;
...@@ -30,7 +30,7 @@ import org.springframework.stereotype.Service; ...@@ -30,7 +30,7 @@ import org.springframework.stereotype.Service;
public class GoogleServiceAccountValidatorImpl implements IServiceAccountValidator { public class GoogleServiceAccountValidatorImpl implements IServiceAccountValidator {
private final NetHttpTransport netHttpTransport = new NetHttpTransport(); private final NetHttpTransport netHttpTransport = new NetHttpTransport();
private final JacksonFactory jacksonFactory = new JacksonFactory(); private final GsonFactory gsonFactory = new GsonFactory();
@Autowired @Autowired
private JaxRsDpsLog log; private JaxRsDpsLog log;
...@@ -46,7 +46,7 @@ public class GoogleServiceAccountValidatorImpl implements IServiceAccountValidat ...@@ -46,7 +46,7 @@ public class GoogleServiceAccountValidatorImpl implements IServiceAccountValidat
@Override @Override
public boolean isValidServiceAccount(String jwt, String userIdentity, String... googleAudiences) { public boolean isValidServiceAccount(String jwt, String userIdentity, String... googleAudiences) {
GoogleIdTokenVerifier verifier = this.verifierGenerator.getVerifier(this.netHttpTransport, this.jacksonFactory, googleAudiences); GoogleIdTokenVerifier verifier = this.verifierGenerator.getVerifier(this.netHttpTransport, this.gsonFactory, googleAudiences);
try { try {
GoogleIdToken idToken = verifier.verify(jwt); GoogleIdToken idToken = verifier.verify(jwt);
if (idToken != null) { if (idToken != null) {
......
...@@ -18,7 +18,7 @@ package org.opengroup.osdu.notification.secutity; ...@@ -18,7 +18,7 @@ package org.opengroup.osdu.notification.secutity;
import com.google.api.client.googleapis.auth.oauth2.GoogleIdTokenVerifier; import com.google.api.client.googleapis.auth.oauth2.GoogleIdTokenVerifier;
import com.google.api.client.http.javanet.NetHttpTransport; import com.google.api.client.http.javanet.NetHttpTransport;
import com.google.api.client.json.jackson2.JacksonFactory; import com.google.api.client.json.gson.GsonFactory;
import org.junit.Assert; import org.junit.Assert;
import org.junit.Test; import org.junit.Test;
import org.junit.runner.RunWith; import org.junit.runner.RunWith;
...@@ -31,7 +31,7 @@ import java.util.Collection; ...@@ -31,7 +31,7 @@ import java.util.Collection;
@RunWith(PowerMockRunner.class) @RunWith(PowerMockRunner.class)
public class GoogleServiceAccountValidatorGeneratorTest { public class GoogleServiceAccountValidatorGeneratorTest {
private final NetHttpTransport netHttpTransport = new NetHttpTransport(); private final NetHttpTransport netHttpTransport = new NetHttpTransport();
private final JacksonFactory jacksonFactory = new JacksonFactory(); private final GsonFactory gsonFactory = new GsonFactory();
private static final String AUDIENCE_1 = "aud1"; private static final String AUDIENCE_1 = "aud1";
private static final String AUDIENCE_2 = "aud2"; private static final String AUDIENCE_2 = "aud2";
...@@ -40,15 +40,15 @@ public class GoogleServiceAccountValidatorGeneratorTest { ...@@ -40,15 +40,15 @@ public class GoogleServiceAccountValidatorGeneratorTest {
@Test @Test
public void should_returnVerifierWithoutAudiences_when_noAudiencesProvided() { public void should_returnVerifierWithoutAudiences_when_noAudiencesProvided() {
GoogleIdTokenVerifier verifier = this.sut.getVerifier(netHttpTransport, jacksonFactory); GoogleIdTokenVerifier verifier = this.sut.getVerifier(netHttpTransport, gsonFactory);
Assert.assertNull(verifier.getAudience()); Assert.assertNull(verifier.getAudience());
} }
@Test @Test
public void should_returnVerifierWithAudiences_when_AudiencesProvided() { public void should_returnVerifierWithAudiences_when_AudiencesProvided() {
GoogleIdTokenVerifier verifier = this.sut.getVerifier(netHttpTransport, jacksonFactory, AUDIENCE_1, AUDIENCE_2); GoogleIdTokenVerifier verifier = this.sut.getVerifier(netHttpTransport, gsonFactory, AUDIENCE_1, AUDIENCE_2);
Collection<String> audiences = verifier.getAudience(); Collection<String> audiences = verifier.getAudience();
Assert.assertTrue(audiences.contains(AUDIENCE_1)); Assert.assertTrue(audiences.contains(AUDIENCE_1));
Assert.assertTrue(audiences.contains(AUDIENCE_2)); Assert.assertTrue(audiences.contains(AUDIENCE_2));
} }
} }
\ No newline at end of file
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment