Skip to content
Snippets Groups Projects

CORE | Adding global exception handler

Merged Komal Makkar requested to merge users/komakkar/addingGlobalExceptionHandler into master

All Submissions:


  • [YES] I have added an explanation of what changes in this merge do and why we should include it?
  • [NO] Does the MR contain pipeline/ helm chart related changes?
  • [NA] I have updated the documentation accordingly.
  • [NA] I have added tests to cover my changes.
  • [YES] All new and existing tests passed.
  • [YES] My code follows the code style of this project.
  • [YES] I ran lint checks locally prior to submission.

What is the issue or story related to the change?


Original Behavior The Global Exception Handler was missing. The Error endpoint was wrapping the exception, but the basic logging was missing.

Modified behavior

  1. Added the Global handler. This will lead to logging almost any exception that happened. It will improve observability and traceability.
  2. Reindexing is not catching all exceptions now, it will flow to the global handler where it gets logged and wrapped. UTs are updated as well.

High level design:

Issue:

Change details:

Test coverage:


Does this introduce a breaking change?


  • [YES/NO] No

Pending items


Reviewer request


  • Please provide an ETA when you plan to review this MR. Write a comment to decline or provide an ETA.
  • Block the MR if you feel there is less testing or no details in the MR
  • Please cover the following aspects in the MR -- Coding design: <Reviewer1> -- Backward Compatibility: <Reviewer2> -- Feature Logic: <Logic design> -- <Any other context mention here> OR -- <Component 1>: <Reviewer1> -- <CosmosDB>: <Reviewer2> -- <ServiceBus> <Reviewer3> -- <Mention any other component and owner>

Other information


Edited by Komal Makkar

Merge request reports

Merge request pipeline #29662 failed

Pipeline: Indexer

#30166

    Merge request pipeline failed for 6037042c

    Deployed to A‎WS‎ 4 years ago
    Deployed to I‎BM‎ 4 years ago
    Approved by

    Merged by MANISH KUMARMANISH KUMAR 4 years ago (Mar 5, 2021 5:52am UTC)

    Merge details

    • Changes merged into master with 974ddcdb (commits were squashed).
    • Deleted the source branch.

    Pipeline #30172 failed

    Pipeline failed for 974ddcdb on master

    Skipped deployment to G‎CP‎
    Deployed to I‎BM‎ 4 years ago
    Deployed to A‎WS‎ 4 years ago

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
    Please register or sign in to reply
    Loading