Fixed invalid expiration date bug in Create/Update Legal Tag API calls

All Submissions:

---

• [YES] I have added an explanation of what changes in this merge do and why we should include it?
• [YES] I have updated the documentation accordingly.
• [YES] I have added tests to cover my changes.
• [YES] All new and existing tests passed.
• [YES] My code follows the code style of this project.
• [YES] I ran lint checks locally prior to submission.

What is the current behavior?

---

When given a long number for ExpirationDate e.g. 5555555555555555 deserializer converts it in a date (178018-07-19) with 6 digit year value. Although Legal tags get created with this date value but Get call later fails because the method expects the date to be in the "yyyy-mm-dd" format. Please refer the link below for details of issue.

Legal Service: POST and PUT Calls Allow Invalid Date Format Causing GET Calls to Fail (#99) · Issues · OSDU / OSDU Data Platform / Security and Compliance / Legal · GitLab

What is the new behavior?

---

Added method to validate length of year part in deserialized expiration date passed for create/update legal tag. If the year length is not equal to 4 request fails with code 400 and Message ""Expiration Date has invalid year <year part>."

Annotation to deserialize the date was missing in model used for Update Legal Tag. so added that as well.

Added unit test to test the expected behavior if a large numeric value is passed for ExpirationDate.

Added unit test for model UpdateLegalTag to test ExpirationDateDeserializer is correctly deserializing the expiration date and @JsonFormat annotation correctly formats the expiration date during deserialization.

Does this introduce a breaking change?

---

• [YES]

Any relevant logs, error output, etc?

---

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Other information

---

legal-core/src/main/java/org/opengroup/osdu/legal/tags/dto/UpdateLegalTag.java

@@ -2,13 +2,17 @@ package org.opengroup.osdu.legal.tags.dto;
 
 import  java.sql.Date;
 import java.util.Map;
-
 import io.swagger.v3.oas.annotations.media.Schema;
 import org.opengroup.osdu.core.common.model.legal.validation.ValidDescription;
 import org.opengroup.osdu.core.common.model.legal.validation.ValidName;
 import lombok.AllArgsConstructor;
 import lombok.Data;
 import lombok.NoArgsConstructor;
+import com.fasterxml.jackson.annotation.JsonFormat;
+import com.fasterxml.jackson.databind.annotation.JsonDeserialize;
+import org.opengroup.osdu.core.common.model.legal.serialization.ExpirationDateDeserializer;
+
+import static org.opengroup.osdu.core.common.util.SerializationUtils.EXPIRATION_DATE_FORMAT;
 
 /**
  * If any class variable changed here,
@@ -32,8 +36,11 @@ public class UpdateLegalTag {
     private String description = "";
 
     @Schema(description = "The optional expiration date of the contract in the format YYYY-MM-DD", example = "2025-12-25")
+    @JsonDeserialize(using = ExpirationDateDeserializer.class)
+    @JsonFormat(shape = JsonFormat.Shape.STRING, pattern = EXPIRATION_DATE_FORMAT)
+
     private Date expirationDate;
 
     @Schema(description = "The optional object field to attach any company specific attributes.")
     private Map<String, Object> extensionProperties;
-}
+}
\ No newline at end of file