Merge branch 'feature/GONRG-940-Implement_audit_events_Legal' into 'integration-master'

GONRG-940 Implement audit events for Legal

Closes GONRG-940

See merge request go3-nrg/platform/security-and-compliance/legal!15

legal-core/src/main/java/org/opengroup/osdu/legal/api/LegalTagApi.java

 package org.opengroup.osdu.legal.api;
 
 import com.google.gson.Gson;
+import java.util.Collections;
 import org.opengroup.osdu.legal.countries.LegalTagCountriesService;
 import org.opengroup.osdu.legal.logging.AuditLogger;
 import org.opengroup.osdu.legal.tags.LegalTagService;
@@ -137,7 +138,7 @@ public class LegalTagApi {
         output.setPersonalDataTypes(allowedLegaltagPropertyValues.getPersonalDataType());
         output.setSecurityClassifications(allowedLegaltagPropertyValues.getSecurityClassifications());
         output.setDataTypes(allowedLegaltagPropertyValues.getDataTypes());
-        auditLogger.readLegalPropertiesSuccess();
+        auditLogger.readLegalPropertiesSuccess(Collections.singletonList(output.toString()));
 
         return new ResponseEntity<ReadablePropertyValues>(output, HttpStatus.OK);
     }

legal-core/src/main/java/org/opengroup/osdu/legal/logging/AuditEvents.java

@@ -82,25 +82,25 @@ public class AuditEvents {
 				.build();
 	}
 
-	public AuditPayload getReadLegalPropertiesEventSuccess() {
+	public AuditPayload getReadLegalPropertiesEventSuccess(List<String> resources) {
 		return AuditPayload.builder()
 				.action(AuditAction.READ)
 				.status(AuditStatus.SUCCESS)
 				.user(this.user)
 				.actionId(READ_ACTION_ID)
 				.message(READ_MESSAGE_SUCCESS)
-				.resources(singletonList(PROPERTY_VALUE))
+				.resources(resources)
 				.build();
 	}
 
-	public AuditPayload getReadLegalPropertiesEventFail() {
+	public AuditPayload getReadLegalPropertiesEventFail(List<String> resources) {
 		return AuditPayload.builder()
 				.action(AuditAction.READ)
 				.status(AuditStatus.FAILURE)
 				.user(this.user)
 				.actionId(READ_ACTION_ID)
 				.message(READ_MESSAGE_FAILURE)
-				.resources(singletonList(PROPERTY_VALUE))
+				.resources(resources)
 				.build();
 	}
 

legal-core/src/main/java/org/opengroup/osdu/legal/logging/AuditLogger.java

@@ -63,12 +63,12 @@ public class AuditLogger {
 		this.writeLog(this.getEvents().getLegalTagStatusJobEventFail(resources));
 	}
 
-	public void readLegalPropertiesSuccess() {
-		this.writeLog(this.getEvents().getReadLegalPropertiesEventSuccess());
+	public void readLegalPropertiesSuccess(List<String> resources) {
+		this.writeLog(this.getEvents().getReadLegalPropertiesEventSuccess(resources));
 	}
 
-	public void readLegalPropertiesFail() {
-		this.writeLog(this.getEvents().getReadLegalPropertiesEventFail());
+	public void readLegalPropertiesFail(List<String> resources) {
+		this.writeLog(this.getEvents().getReadLegalPropertiesEventFail(resources));
 	}
 
 	public void validateLegalTagSuccess() {

legal-core/src/test/java/org/opengroup/osdu/legal/api/LegalTagApiTests.java

@@ -268,6 +268,6 @@ public class LegalTagApiTests {
     public void shouldCreateAuditLogs_when_getLegalTagProperties() {
         sut.getLegalTagProperties();
 
-        verify(auditLogger).readLegalPropertiesSuccess();
+        verify(auditLogger).readLegalPropertiesSuccess(any());
     }
 }

legal-core/src/test/java/org/opengroup/osdu/legal/logging/AuditLoggerTests.java

@@ -67,13 +67,13 @@ public class AuditLoggerTests {
 
     @Test
     public void should_writeLegalTagReadPropertiesSuccessEvent(){
-        sut.readLegalPropertiesSuccess();
+        sut.readLegalPropertiesSuccess(any());
         verify(log).audit(any());
     }
 
     @Test
     public void should_writeLegalTagReadPropertiesFailEvent(){
-        sut.readLegalPropertiesFail();
+        sut.readLegalPropertiesFail(any());
         verify(log).audit(any());
     }