Improve code coverage (!21) · Merge requests · OSDU Software / OSDU Data Platform / Security and Compliance / entitlements-azure · GitLab

This is an archived project. Repository and other project resources are read-only.

Aalekh Jain requested to merge improve-code-coverage into master Sep 17, 2020

All Submissions:

[NO] Have you followed our code review guidelines?
[YES] Have you added an explanation of what your changes do and why you'd like us to include them?
[NA] I have updated the documentation accordingly.
[YES] I have added tests to cover my changes.
[NO] All new and existing tests passed.
[YES] My code follows the code style of this project.
[NO] I ran lint checks locally prior to submission.

What is the current behavior?

Insufficient code coverage in entitlements service.

What is the new behavior?

Added UTs for improving code coverage of entitlements service.

Does this introduce a breaking change?

[NO]

Other information

Build for this MR fails because of the bug in validating email address (#2 (closed)). This needs to be fixed.

cc: @kibattul @kiveerap @amaverma

Edited Sep 22, 2020 by Aalekh Jain