Enabled KeyVault to the test framework and align pattern.

Summary

This merge request refactors and enhances the configuration, variables, and testing for multiple Azure modules (app-insights, keyvault, log-analytics). These changes address simplification of resource attributes, improved modularity, and better testing coverage.

---

Key Changes

app-insights Module

1. Modified test.sh Script:
   • Renamed variables in .tfvars content:
     • appinsights_name → name
     • service_plan_resource_group_name → resource_group_name
     • Added a new location parameter.
   • Simplified default resource tags to osdu = "module".
2. Updated main.tf:
   • Changed dependency injection:
     • No longer relies on a resource_group module.
     • Variables appinsights_name, service_plan_resource_group_name, and others now align with module-level variables (var.name, var.resource_group_name, etc.).
   • Removed unnecessary depends_on for resource group creation.
3. Added Input Variables:
   • New variables (name, resource_group_name, location, and resource_tags) make module configuration explicit and modular.
4. Modified unit_test.go:
   • Updated test variables and expected outputs:
     • name and resource_group_name are now dynamic for tests.
     • Resource count decreased for simplified resources.
   • Tags validation added for app insights resources.

---

keyvault Module

1. New test.sh Script:
   • Added a new test script for simplifying Key Vault setup and .tfvars generation.
   • Supports environment variable overrides for key vault configuration (e.g., KEYVAULT_NAME, PUBLIC_NETWORK_ACCESS, PURGE_PROTECTION).
2. Refactored main.tf:
   • Directly references keyvault variables instead of a resource_group module.
   • Introduced modular variables for flexibility:
     • keyvault_name, resource_group_name, resource_tags, etc.
3. Revised Variables:
   • public_network_access_enabled now defaults to true.
   • keyvault_purge_protection_enabled defaults changed to false.
   • Added a complete set of tagged inputs for testing and customization.
4. Updated unit_test.go:
   • Test variable setup now uses keyvault_name and dynamic unique IDs.
   • Ensures correct validation of tags and sku for Key Vault resources.

---

log-analytics Module

1. Modified test.sh:
   • Restructured .tfvars content for clarity:
     • Added explicit tagging and refined workspace-specific configurations.
     • Format enhancements for better future maintainability.
2. Refactored main.tf:
   • Removed dependency on a resource_group module; now directly uses var.resource_group_name.
   • Modularized input parameters (name, solutions, resource_tags) with default values.
3. New Input Variables in main.tf:
   • Added solutions as a list of objects for workspace integrations:
     • Includes ContainerInsights by default configurable through inputs.
   • Introduced resource_tags for custom tagging.
4. Updated unit_test.go:
   • Test setup now uses dynamic names for the Log Analytics workspace.
   • Verifies retention_in_days and custom tags for validated resource configurations.

---

Technical Details

• Cross-module Updates:
  • Dependency on resource_group modules removed wherever applicable, ensuring clearer abstractions and reduced dependencies.
  • Input variables now allow dynamic configuration for location, resource tags, and module-specific options.
• Testing Enhancements:
  • Test fixture refinements focus on dynamic, modular configuration using unique IDs to avoid state conflicts.
  • Reduced expected resource count for tests by consolidating unnecessary resources or dependencies.
• Default Behavior Changes:
  • Resources now use consistent default regions (eastus2) and tagging schemas.
  • Defensive validations tightened (keyvault_name format checks, bool settings for PURGE_PROTECTION, etc.).

approved this merge request

added 1 commit

• 411785a7 - Fixed formatting

Compare with previous version

merged

mentioned in commit 35c33bfa

changed milestone to %M25 - Release 0.28

Hi, this is a friendly reminder to assign appropriate labels and milestone to your future merge requests. Proper labeling and milestone assignment help us to track and prepare effectively for upcoming milestone releases.