What is the need for implementing BlobStorageClient by CSPs

There are two interfaces that need to be implemented by CSPs BlobStorageClient and BaseCredentials. I see currently BaseCredentials is being used to generate token. What is the purpose of adding BlobStorageClient and by when CSPs need to implement this interface?

assigned to @alan.henson and @Kateryna_Kurach

added 1 deleted label

assigned to @Siarhei_Khaletski

added R3 Development label

added Manifest Based label

@kibattul sorry if something was not clear in README files. Basically, we have types.py module where hold all types (interfaces).

You're right, BaseCredentials type is responsible for the interface of work with token. BlobStorageClient is a basic interface for providers to implement own logic to work with stored files. For GCP implementation we hold, for instance, service account file in GCS Bucket. This SA file involved in Refresh token logic. Any of vendor can follow this approach and store their SA files (if any) in cloud storage service on the provider side, for instance, AWS can store files in S3.

I'd say we had a transitional phase and during the providing vendor agnostic approach we move from hardcoded part to separate class.

(!) Please, keep in mind that we will provide some updates for M4. We moved part of the logic to Python SDK. Because of the code freezing we not published yet.

@Siarhei_Khaletski Is the BlobStorageClient is used in context of token generation only? I wanted to understand the usecase so that we can decide whether to implement this or not. For example, In authentication flows azure doesn't need this BlobStorageClient implementation. I am trying to understand are there any other flows where this class needs to be implemented from azure side

Actually it's just an abstraction over a logic with blobs that was created during removing GCP hardcoded dependencies.

Of course, if your implementation does not imply using of blobs then you don't need to implements this on your side.

@Siarhei_Khaletski Ok it makes sense. If it is used internally then why should it be exposed as part of types? If we can keep clear distinction between what are the interfaces that are needed by all CSPs and what are specific to one CSP

Going to review that. Potentially, the class will be moved under CSP folder.

That will be great. I will avoid confusion for CSPs.

added M5 label

We'll move this post-R3. We'll initially target M5 and will revisit as necessary.

added 1 deleted label

added OSDU PythonSDK label

added Ingestion Developer label

Within the MR 61ca4e2a was changed README.md file and removed import dependencies.

Now it does not require to create/extend BlobStorageClient by CSPs.

Within M5 we're going to move the logic from types.py module.

added KBUp Next label and removed 1 deleted label

Issue addressed by removing requirement to implement from other CSPs.

closed