Skip to content

Fail fast before fetching blob

Hema Vishnu Pola [Microsoft] requested to merge core-optimizations into master

Type of change

  • Bug Fix
  • Feature

Please provide link to gitlab issue or ADR(Architecture Decision Record)

Does this introduce a change in the core logic?

  • [YES] - Instead of waiting to fetch blob and then failing in ACL, made to fail fast and fetch the blob post that. Please do validate if it does make sense and doesn't disturb any of the flow.

Does this introduce a change in the cloud provider implementation, if so which cloud?

  • AWS
  • Azure
  • GCP
  • IBM

Does this introduce a breaking change?

  • [NO]

What is the current behavior?

After fetching the blob, then ACL checks are done.

What is the new/expected behavior?

Reversing the order to fetch blob only when ACL checks succeed. This would allow to fail fast before loading the whole blob.

Have you added/updated Unit Tests and Integration Tests?

Any other useful information

Merge request reports