Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • S Storage
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 56
    • Issues 56
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 18
    • Merge requests 18
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Open Subsurface Data Universe Software
  • Platform
  • System
  • Storage
  • Merge requests
  • !136

Fail fast before fetching blob

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Hema Vishnu Pola [Microsoft] requested to merge core-optimizations into master Feb 04, 2021
  • Overview 3
  • Commits 1
  • Pipelines 2
  • Changes 1

Type of change

  • Bug Fix
  • Feature

Please provide link to gitlab issue or ADR(Architecture Decision Record)

Does this introduce a change in the core logic?

  • [YES] - Instead of waiting to fetch blob and then failing in ACL, made to fail fast and fetch the blob post that. Please do validate if it does make sense and doesn't disturb any of the flow.

Does this introduce a change in the cloud provider implementation, if so which cloud?

  • AWS
  • Azure
  • GCP
  • IBM

Does this introduce a breaking change?

  • [NO]

What is the current behavior?

After fetching the blob, then ACL checks are done.

What is the new/expected behavior?

Reversing the order to fetch blob only when ACL checks succeed. This would allow to fail fast before loading the whole blob.

Have you added/updated Unit Tests and Integration Tests?

Any other useful information

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: core-optimizations