Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • Search Search
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 43
    • Issues 43
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 7
    • Merge requests 7
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Open Subsurface Data Universe SoftwareOpen Subsurface Data Universe Software
  • Platform
  • System
  • SearchSearch
  • Merge requests
  • !177

Fix nested query building for queries with similar properties in it

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Rustam Lotsmanenko (EPAM) requested to merge bugfix-fix-nested-query into master Oct 22, 2021
  • Overview 13
  • Commits 9
  • Pipelines 26
  • Changes 6

Description:

Bugfix for nested queries with similar properties in it, example:

"nested(data.VerticalMeasurements, (VerticalMeasurementID:\"Rotary Table\" AND VerticalMeasurement:(>30)))"

Such queries were transformed into malformed queries like:

"query_string": {
"query": "(data.data.VerticalMeasurements.VerticalMeasurements.VerticalMeasurementID:\"Rotary Table\" AND VerticalMeasurement:(>30))"

Which cause 400(Bad request) responses from elastic.

After fixing queries with similar properties works as expected:

"query_string": {
"query": "(data.VerticalMeasurements.VerticalMeasurementID:\"Rotary Table\" AND data.VerticalMeasurements.VerticalMeasurement:(>30))",

Partially solves the issue: #57 (closed)

Changes include:

  • Refactor (a non-breaking change that improves code maintainability).
  • Bugfix (a non-breaking change that solves an issue).
  • New feature (a non-breaking change that adds functionality).
  • Breaking change (a change that is not backward-compatible and/or changes current functionality).

Changes in:

  • Common code

Dev Checklist:

  • Added Unit Tests, wherever applicable.
  • Updated the Readme, if applicable.
  • Existing Tests pass
  • Verified functionality locally
  • Self Reviewed my code for formatting and complex business logic.
Edited Nov 15, 2021 by Rustam Lotsmanenko (EPAM)
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: bugfix-fix-nested-query