Skip to content

BugFix: Fixing Custom Dimensions and Spring App Name

Aman Verma requested to merge users/amaverma/fixCoreLibVersion into master

All Submissions:

  • [YES] I have added an explanation of what changes in this merge do and why we should include it? YES
  • [YES] Does the MR contain pipeline/ helm chart related changes? NO
  • [NA] I have updated the documentation accordingly. NA
  • [NA] I have added tests to cover my changes. NA
  • [YES] All new and existing tests passed. YES
  • [YES] My code follows the code style of this project. YES
  • [NA] I ran lint checks locally prior to submission. NA

What is the issue or story related to the change?

  • The correlation id in custom dimensions was not getting populated automatically for schema service as of now.
  • The spring app name was set to schema whereas container name was set to schema-service. Due to this the dashboards started failing as we pass in container name in query.

High level design: The latest core-lib-azure library has logic in place to populate the correlation id in custom dimensions. Updating the core-lib-azure version should fix it. Using consistent naming for both spring app name as well as container name will solve the dashboard failure.

Issue:

Change details:

  • Updated the core-lib-azure version
  • Made spring app name same as container name.

Validated the changes by running service locally. Logs in AI have correlation id populated now. As well the spring app name is also same as container name.

Sample log

Schema.app End Web-API GET /schema Headers: {correlation-id:db59025f-219f-4c97-b714-b91edc7118d8,content-type:application/json} status=200 time=41179 ms {correlation-id=db59025f-219f-4c97-b714-b91edc7118d8, data-partition-id=opendes}

Test coverage:

NA

Does this introduce a breaking change?

  • [NO]

Pending items

NONE

Reviewer request

  • Please provide an ETA when you plan to review this MR. Write a comment to decline or provide an ETA.
  • Block the MR if you feel there is less testing or no details in the MR
  • Please cover the following aspects in the MR -- Coding design: <Reviewer1> -- Backward Compatibility: <Reviewer2> -- Feature Logic: <Logic design> -- <Any other context mention here> OR -- <Component 1>: <Reviewer1> -- <CosmosDB>: <Reviewer2> -- <ServiceBus> <Reviewer3> -- <Mention any other component and owner>

Other information

cc: @polavishnu @kibattul

Edited by Abhishek Patil

Merge request reports