Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Register
  • Sign in
  • R Register
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 8
    • Merge requests 8
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Open Subsurface Data Universe SoftwareOpen Subsurface Data Universe Software
  • Platform
  • System
  • Register
  • Merge requests
  • !38

Whitelisting endpoint for integration tests.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Komal Makkar requested to merge users/komakkar/whitelistEndpointForIT into master Nov 15, 2020
  • Overview 4
  • Commits 2
  • Pipelines 4
  • Changes 1

All Submissions:


  • [YES] I have added an explanation of what changes in this merge do and why we should include it?
  • [YES] I have updated the documentation accordingly.
  • [NA] I have added tests to cover my changes.
  • [NA] All new and existing tests passed.
  • [YES] My code follows the code style of this project.
  • [NA] I ran lint checks locally prior to submission.

What is the issue or story related to the change?


The ITs for notification service use a TEST rest endpoint. The same is being whitelisted in Istio config. This endpoint has it's own authZ and authN mechanism (HMAC) and it does not invoke Istio or entitlement service.

High level design:

Issue:

Change details:

Test coverage:


NA

Does this introduce a breaking change?


  • [YES/NO] NO

Pending items


The following issue is made to protect the endpoint's authz and authn mechanism. #24 (closed)

Reviewer request


  • Please provide an ETA when you plan to review this MR. Write a comment to decline or provide an ETA.
  • Block the MR if you feel there is less testing or no details in the MR
  • Please cover the following aspects in the MR -- Coding design: -- Backward Compatibility: -- Feature Logic: -- OR -- <Component 1>: -- : -- --
Edited Nov 18, 2020 by Komal Makkar
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: users/komakkar/whitelistEndpointForIT