Skip to content

Whitelisting endpoint for integration tests.

Komal Makkar requested to merge users/komakkar/whitelistEndpointForIT into master

All Submissions:

  • [YES] I have added an explanation of what changes in this merge do and why we should include it?
  • [YES] I have updated the documentation accordingly.
  • [NA] I have added tests to cover my changes.
  • [NA] All new and existing tests passed.
  • [YES] My code follows the code style of this project.
  • [NA] I ran lint checks locally prior to submission.

What is the issue or story related to the change?

The ITs for notification service use a TEST rest endpoint. The same is being whitelisted in Istio config. This endpoint has it's own authZ and authN mechanism (HMAC) and it does not invoke Istio or entitlement service.

High level design:

Issue:

Change details:

Test coverage:

NA

Does this introduce a breaking change?

  • [YES/NO] NO

Pending items

The following issue is made to protect the endpoint's authz and authn mechanism. #24 (closed)

Reviewer request

  • Please provide an ETA when you plan to review this MR. Write a comment to decline or provide an ETA.
  • Block the MR if you feel there is less testing or no details in the MR
  • Please cover the following aspects in the MR -- Coding design: -- Backward Compatibility: -- Feature Logic: -- OR -- <Component 1>: -- : -- --
Edited by Komal Makkar

Merge request reports