Fix Failing Unit Tests
The CRS conversion unit tests were not all running (approx 80 were missing) due to maven-surefire-plugin not being installed and the test naming not using a supported convention. This issue was fixed by this MR: !262 (merged)
However, 4 unit tests failed after they were re-enabled. To prevent the build from failing, the failing tests were ignored and this issue was created to track them. The failing tests are:
- EsriWktTransformTests.testNTv2Wkt
- CrsConverterApiV3Tests.convertBinGridSizeErrorTest
- CrsConverterApiV3Tests.convertBinGridWithSuccessfulResponse
- CrsConverterApiV3Tests.convertBinGridWithSuccessfulResponseWithToCRS
The error log is below:
[INFO] Running org.opengroup.osdu.crs.converter.EsriWktTransformTests
[ERROR] Tests run: 12, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 6.429 s <<< FAILURE! - in org.opengroup.osdu.crs.converter.EsriWktTransformTests
[ERROR] testNTv2Wkt(org.opengroup.osdu.crs.converter.EsriWktTransformTests) Time elapsed: 0.042 s <<< ERROR!
java.lang.IllegalArgumentException: Invalid source and/or target CRS specification.
at org.opengroup.osdu.crs.converter.EsriWktTransformTests.testNTv2Wkt(EsriWktTransformTests.java:275)
[ERROR] Tests run: 3, Failures: 0, Errors: 3, Skipped: 0, Time elapsed: 0.027 s <<< FAILURE! - in org.opengroup.osdu.crs.api.CrsConverterApiV3Tests
[ERROR] convertBinGridSizeErrorTest(org.opengroup.osdu.crs.api.CrsConverterApiV3Tests) Time elapsed: 0.014 s <<< ERROR!
java.lang.Exception: Unexpected exception, expected<javax.validation.ValidationException> but was<java.lang.NullPointerException>
at org.opengroup.osdu.crs.api.CrsConverterApiV3Tests.convertBinGridSizeErrorTest(CrsConverterApiV3Tests.java:84)
[ERROR] convertBinGridWithSuccessfulResponse(org.opengroup.osdu.crs.api.CrsConverterApiV3Tests) Time elapsed: 0.005 s <<< ERROR!
java.lang.NullPointerException
at org.opengroup.osdu.crs.api.CrsConverterApiV3Tests.convertBinGridWithSuccessfulResponse(CrsConverterApiV3Tests.java:58)
[ERROR] convertBinGridWithSuccessfulResponseWithToCRS(org.opengroup.osdu.crs.api.CrsConverterApiV3Tests) Time elapsed: 0.002 s <<< ERROR!
java.lang.NullPointerException
at org.opengroup.osdu.crs.api.CrsConverterApiV3Tests.convertBinGridWithSuccessfulResponseWithToCRS(CrsConverterApiV3Tests.java:70)