Skip to content
GitLab

[Core] [Azure] Adding handshake filter

Merged Komal Makkar requested to merge users/komakkar/handshakeFilter into master

All Submissions:

  • [YES] I have added an explanation of what changes in this merge do and why we should include it?
  • [YES] I have updated the documentation accordingly.
  • [YES] I have added tests to cover my changes.
  • [YES] All new and existing tests passed.
  • [YES] My code follows the code style of this project.
  • [YES] I ran lint checks locally prior to submission.

What is the issue or story related to the change?

High level design:

Issue: #16 (closed)

Change details:

The changes are done for the following.

  1. Reaction to Storage service publishing to event grid. The format in which the event is generated changed in the storage service. The same is accommodated here. SAMPLE EVENT [ { "id": "32197ce0-3ee7-46e3-92a2-d2788d2b94d2", "subject": "RecordsChanged", "data": { "data": [ { "id": "opendes:doc:6a6f917dbab6479dad548d71515131c5", "kind": "opendes:at:wellbore:1.0.0", "op": "create" }, { "id": "opendes:doc:6d6246ace0964b419cec6f32c05c21ae", "kind": "opendes:at:wellbore:1.0.0", "op": "create" } ], "account-id": "opendes", "correlation-id": "c3718fb5-d60e-45bd-a2d3-48d3c2bdd7e7", "data-partition-id": "opendes" }, "eventType": "RecordsChanged", "dataVersion": "1.0", "metadataVersion": "1", "eventTime": "2020-12-28T12:09:42.331Z", "topic": "fhtfc" } ]

  2. Handshake request #16 (closed) is addressed. Filter of order 0 is written.

Test coverage:

Does this introduce a breaking change?

  • No

DISCLAIMER: We are using a filter for handshake requests. This filter is blindly accepting ALL the calls for handshake requests. There is a security vulnerability as we are not validating anything. This is might make it easy for anyone to make a DOS attack.

Pending items

Reviewer request

  • Please provide an ETA when you plan to review this MR. Write a comment to decline or provide an ETA.
  • Block the MR if you feel there is less testing or no details in the MR
  • Please cover the following aspects in the MR -- Coding design: <Reviewer1> -- Backward Compatibility: <Reviewer2> -- Feature Logic: <Logic design> -- <Any other context mention here> OR -- <Component 1>: <Reviewer1> -- <CosmosDB>: <Reviewer2> -- <ServiceBus> <Reviewer3> -- <Mention any other component and owner>

Other information

Edited by Komal Makkar