Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • O OS Core Common
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 30
    • Issues 30
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Open Subsurface Data Universe Software
  • Platform
  • System
  • Lib
  • core
  • OS Core Common
  • Merge requests
  • !29

Refactor http body parsing

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Pavel Bachyla requested to merge refactor_http_body_parsing into master Oct 12, 2020
  • Overview 29
  • Commits 11
  • Pipelines 25
  • Changes 25

Resolves the issue: [Bug] expirationDate failed to be parsed by Gson

  1. Move the parsing logic of the HttpResponse#body field to a separate class.
  2. Replace gson->jackson
  3. Encapsulate the internal implementation of the parsing so that clients will not be affected if any low-level changes happen in the parsing logic.

Changes include

  • Refactoring
  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • Added Unit Tests, wherever applicable.
  • Updated the Readme
  • Existing Tests pass: The test shouldSuccessfullySerializeLegalTag is breaking in the existing code.
  • Verified functionality locally
  • Self Reviewed my code for formatting and complex business logic.
Edited Oct 23, 2020 by ethiraj krishnamanaidu
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: refactor_http_body_parsing