[Bug] expirationDate failed to be parsed by Gson
Field expirationDate in org.opengroup.osdu.core.common.model.legal.Properties is a java.sql.Date in OSDU. But HttpResponse uses Gson to parse the body. Gson failed when it try to parse the JSON in
org.opengroup.osdu.core.common.http.HttpResponse.parseBody
It throws an exception
com.google.gson.JsonSyntaxException: java.text.ParseException: Unparseable date: "2099-12-31"
at com.google.gson.internal.bind.SqlDateTypeAdapter.read(SqlDateTypeAdapter.java:59)
at com.google.gson.internal.bind.SqlDateTypeAdapter.read(SqlDateTypeAdapter.java:38)
at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$1.read(ReflectiveTypeAdapterFactory.java:131)
at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$Adapter.read(ReflectiveTypeAdapterFactory.java:222)
at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$1.read(ReflectiveTypeAdapterFactory.java:131)
at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$Adapter.read(ReflectiveTypeAdapterFactory.java:222)
at com.google.gson.Gson.fromJson(Gson.java:927)
at com.google.gson.Gson.fromJson(Gson.java:892)
at com.google.gson.Gson.fromJson(Gson.java:841)
at com.google.gson.Gson.fromJson(Gson.java:813)
at org.opengroup.osdu.core.common.http.HttpResponse.parseBody(HttpResponse.java:81)
at org.opengroup.osdu.core.common.legal.LegalService.getResult(LegalService.java:95)
at org.opengroup.osdu.core.common.legal.LegalService.get(LegalService.java:54)
at org.opengroup.osdu.core.common.legal.LegalServiceTest.should_returnLegaltag_when_httpResponseIsNotEmpty(LegalServiceTest.java:54)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.mockito.internal.runners.JUnit45AndHigherRunnerImpl.run(JUnit45AndHigherRunnerImpl.java:37)
at org.mockito.runners.MockitoJUnitRunner.run(MockitoJUnitRunner.java:62)
at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)
at com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33)
at com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:220)
at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:53)
Caused by: java.text.ParseException: Unparseable date: "2099-12-31"
at java.text.DateFormat.parse(DateFormat.java:366)
at com.google.gson.internal.bind.SqlDateTypeAdapter.read(SqlDateTypeAdapter.java:56)
... 37 more
Gson is a very simple parser. It will parse java.sql.Date into format "MMM d, yyyy" while our date format is "yyyy-MM-dd". I created a unit test LegalServiceTest to reproduce this issue.