Skip to content
GitLab

Managing common properties from core-lib-azure

Merged Abhishek Patil requested to merge abpatil/common_config into master

All Submissions:

  • [YES] I have added an explanation of what changes in this merge do and why we should include it?
  • [YES] I have updated the documentation accordingly.
  • [NA] I have added tests to cover my changes.
  • [YES] All new and existing tests passed.
  • [YES] My code follows the code style of this project.
  • [NA] I ran lint checks locally prior to submission.

What is the issue or story related to the change?

There are various configuration properties which are common across all OSDU services. Any update/addition to these common properties require change in each and every service using it.

High level design: https://microsoft.sharepoint.com/:w:/t/EnergyDataPlatform/EckjpjanywtMhRIzwgHotXABpRuHueQl1GSmdySPn0tNnw?e=XfZIlw

Issue: https://dev.azure.com/msazure/One/_sprints/taskboard/Azure%20Global%20Engineering%20Energy%20Team/One/AGE/Cobalt/May?workitem=9872385

Change details:

Adding common.properties file which will contain all the configuration properties which are common across all OSDU services. Services will use this common.properties along with their own application.properties.

Test coverage:

Does this introduce a breaking change?

  • [NO]

Pending items

Reviewer request

  • Please provide an ETA when you plan to review this MR. Write a comment to decline or provide an ETA.
  • Block the MR if you feel there is less testing or no details in the MR
  • Please cover the following aspects in the MR -- Coding design: <Reviewer1> -- Backward Compatibility: <Reviewer2> -- Feature Logic: <Logic design> -- <Any other context mention here> OR -- <Component 1>: <Reviewer1> -- <CosmosDB>: <Reviewer2> -- <ServiceBus> <Reviewer3> -- <Mention any other component and owner>

Other information