Skip to content

Exception handling fix in CosmosStore

Abhishek Patil requested to merge abpatil/exception_handling_fix into master

All Submissions:

  • [YES] I have added an explanation of what changes in this merge do and why we should include it?
  • [YES] I have updated the documentation accordingly.
  • [NA] I have added tests to cover my changes.
  • [YES] All new and existing tests passed.
  • [YES] My code follows the code style of this project.
  • [NO] I ran lint checks locally prior to submission.

What is the issue or story related to the change?

AppException is not handled in getCosmosContainer method in CosmosStore class. Due to this, for every exception in getCosmosContainer method, 500 error code is thrown.

High level design: None

Issue: None

Change details: Added code to handle AppException in getCosmosContainer method. This will make sure that correct error code is thrown instead of just throwing 500 error code for every exception.

Test coverage:

NA

Does this introduce a breaking change?

  • [NO]

Pending items

None

Reviewer request

  • Please provide an ETA when you plan to review this MR. Write a comment to decline or provide an ETA.
  • Block the MR if you feel there is less testing or no details in the MR
  • Please cover the following aspects in the MR -- Coding design: <Reviewer1> -- Backward Compatibility: <Reviewer2> -- Feature Logic: <Logic design> -- <Any other context mention here> OR -- <Component 1>: <Reviewer1> -- <CosmosDB>: <Reviewer2> -- <ServiceBus> <Reviewer3> -- <Mention any other component and owner>

Other information

Merge request reports