Cherry-pick 'Fix parsing string arrays' into release/0.25

Original MR: !693 (merged)

This MR is a Cherry Pick into a Release Branch.

After the release branch is first created, any subsequent changes use this process to update the release (often resulting in a new patch tag) without incorporating all changes in the default branch. These MRs must be approved by the PMC before they are merged, since they alter the scope of the release. To see more details about the change itself, look at the Original MR listed above.

Skipped Pipeline

Normally, pipelines are not executed on the cherry pick branch/MR prior to merging. This optimization is accepted because the code was tested when it merged into the default branch, and will be tested again in the release branch prior to tagging. However, if anybody feels that the MR requires further scrutiny -- whether because it had conflicts in the cherry-picking, it interfaces with some drastically altered logic between the branches, or any other reason -- we can run the pipeline here prior to merging.

If There's Reason to Run a Pipeline

If you want to see a pipeline result before this merges, first add a comment explaining why you'd like to see the pipeline results so the PMC and others know your thinking. Then, mark the MR as a Draft MR (using the vertical ellipsis above, choose 'Mark as Draft'). This prevents the MR from being approved & merged accidentally by a busy release coordinator who didn't see your comment. Finally, if you are a maintainer on the project, launch a pipeline on this branch. Since this branch is a protected branch and the MR has no-detached-pipeline set, all integration tests will run and there's no need for any trusted-* branches.

Launch a Pipeline for this Branch

indexer-core/src/main/java/org/opengroup/osdu/indexer/service/AttributeParsingServiceImpl.java

@@ -64,8 +64,12 @@ public class AttributeParsingServiceImpl implements IAttributeParsingService {
     @Override
     public void tryParseValueArray(Class<?> attributeClass, String recordId, String attributeName, Object attributeVal, Map<String, Object> dataMap) {
         BiFunction<String, Object, ?> parser;
-        ElasticType elasticType = ElasticType.forValue(attributeClass.getSimpleName());
+        ElasticType elasticType = attributeClass != String.class ? ElasticType.forValue(attributeClass.getSimpleName()) : ElasticType.TEXT;
         switch (elasticType) {
+            case TEXT:
+            case KEYWORD:
+                parser = this.stringParser::parseString;
+                break; 
             case DOUBLE:
                 parser = this.numberParser::parseDouble;
                 break;
@@ -91,7 +95,7 @@ public class AttributeParsingServiceImpl implements IAttributeParsingService {
         }
 
         try {
-            List<String> parsedStringList = isArrayType(attributeVal);
+            List<String> parsedStringList = isArrayType(attributeVal, attributeClass);
             List out = new ArrayList<>();
             for (Object o : parsedStringList) {
                 out.add(parser.apply(attributeName, o));
@@ -232,8 +236,17 @@ public class AttributeParsingServiceImpl implements IAttributeParsingService {
     }
 
 
-    private List<String> isArrayType(Object attributeVal) {
-        try {
+    private List<String> isArrayType(Object attributeVal, Class<?> attributeClass) {
+        // Handling string arrays as they're not valid JSON for code below
+        if (attributeVal != null && attributeClass == String.class && attributeVal instanceof List<?>) {
+            List<String> result = new ArrayList<>();
+            for (Object item: (List<Object>)(List<?>) attributeVal) {
+                result.add(item == null ? null : String.valueOf(item));
+            }
+            return result;
+        }
+        
+        try { 
             String value = attributeVal == null ? null : String.valueOf(attributeVal);
             if (attributeVal == null || Strings.isNullOrEmpty(value)) {
                 return Collections.EMPTY_LIST;