refactor unit tests

indexer-core/src/test/java/org/opengroup/osdu/indexer/api/ReindexApiTest.java

@@ -92,7 +92,7 @@ public class ReindexApiTest {
         ResponseEntity<?> response = sut.reindexRecords(new ReindexRecordsRequest(recordIds));
 
         assertEquals(HttpStatus.ACCEPTED, response.getStatusCode());
-        verify(auditLogger).getReindex(any());
+        verify(auditLogger).getReindexRecords(any());
     }
 
     @Test

indexer-core/src/test/java/org/opengroup/osdu/indexer/service/StorageServiceImplTest.java

@@ -190,14 +190,16 @@ public class StorageServiceImplTest {
     @Test
     public void should_returnStorageRecords_givenRecordIds_getValidStorageRecordsTest() throws URISyntaxException {
 
-        String validDataFromStorage = "{\"records\":[{\"id\":\"testid\", \"version\":1, \"kind\":\"tenant:test:test:1.0.0\"}],\"notFound\":[\"invalid1\"], \"conversionStatuses\": []}";
+        String validDataFromStorage = "{\"records\":[{\"id\":\"tenant1:doc:1dbf528e0e0549cab7a08f29fbfc8465\", \"version\":1, \"kind\":\"tenant:test:test:1.0.0\"}]}";
 
         HttpResponse httpResponse = mock(HttpResponse.class);
         when(httpResponse.getBody()).thenReturn(validDataFromStorage);
 
-        when(configurationProperties.getStorageQueryRecordForConversionHost()).thenReturn("storageUrl");
+        when(configurationProperties.getStorageQueryRecordHost()).thenReturn("storageUrl");
         when(this.httpClientHandler.sendRequest(any(), any())).thenReturn(httpResponse);
-        Records storageRecords = this.sut.getStorageRecords(ids);
+        List<String> idsCopy = new ArrayList<>();
+        idsCopy.addAll(ids);
+        Records storageRecords = this.sut.getStorageRecords(idsCopy);
 
         assertEquals(1, storageRecords.getRecords().size());
         assertEquals(1, storageRecords.getNotFound().size());