do get, then check instead of check, then get when using cache

indexer-core/src/main/java/org/opengroup/osdu/indexer/service/PropertyConfigurationsServiceImpl.java

@@ -151,15 +151,13 @@ public class PropertyConfigurationsServiceImpl implements PropertyConfigurations
                     } else {
                         List<SearchRecord> childrenRecords = searchChildrenRecords(relatedObjectsSpec.getRelatedObjectKind(), relatedObjectsSpec.getRelatedObjectID(), objectId);
                         for (SearchRecord record : childrenRecords) {
-                            Map<String, Object> childDataMap;
                             // If the child record is in the cache, that means the record was updated very recently.
-                            // The search result from elasticsearch may not be the latest version.
-                            if(this.relatedObjectCache.get(record.getId()) != null) {
-                                childDataMap = this.relatedObjectCache.get(record.getId());
-                            }
-                            else {
+                            // In this case, use the cache's record instead of the record from search result
+                            Map<String, Object> childDataMap = this.relatedObjectCache.get(record.getId());
+                            if(childDataMap == null) {
                                 childDataMap = record.getData();
                             }
+
                             Map<String, Object> propertyValues = getPropertyValues(childDataMap, path.getValueExtraction(), configuration.isExtractFirstMatch());
                             propertyValues = PropertyUtil.replacePropertyPaths(configuration.getName(), path.getValueExtraction().getValuePath(), propertyValues);
                             if (allPropertyValues.isEmpty() && configuration.isExtractFirstMatch()) {